Skip to content

Commit

Permalink
fixed api audit tests
Browse files Browse the repository at this point in the history 
(cherry picked from commit 2809bdb)
  • Loading branch information
@pondrejk @web-flow
pondrejk authored and web-flow committed Dec 11, 2023
1 parent 00e050d commit 0ed4dc7
Showing 1 changed file with 34 additions and 32 deletions.
66 changes: 34 additions & 32 deletions tests/foreman/api/test_audit.py
View file
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ def test_positive_create_by_type(target_sat):
:CaseImportance: Medium
"""
for entity_item in [
{'entity': target_sat.api.Architecture()},
{'entity': target_sat.api.Architecture(), 'entity_type': 'architecture'},
{
'entity': target_sat.api.AuthSourceLDAP(),
'entity_type': 'auth_source',
Expand All @@ -50,30 +50,36 @@ def test_positive_create_by_type(target_sat):
'entity_type': 'compute_resource',
'value_template': '{entity.name} (Libvirt)',
},
{'entity': target_sat.api.Domain()},
{'entity': target_sat.api.Host()},
{'entity': target_sat.api.HostGroup()},
{'entity': target_sat.api.Domain(), 'entity_type': 'domain'},
{'entity': target_sat.api.Host(), 'entity_type': 'host'},
{'entity': target_sat.api.HostGroup(), 'entity_type': 'hostgroup'},
{
'entity': target_sat.api.Image(
compute_resource=target_sat.api.LibvirtComputeResource().create()
)
),
'entity_type': 'image',
},
{'entity': target_sat.api.Location()},
{'entity': target_sat.api.Location(), 'entity_type': 'location'},
{'entity': target_sat.api.Media(), 'entity_type': 'medium'},
{
'entity': target_sat.api.OperatingSystem(),
'entity_type': 'os',
'value_template': '{entity.name} {entity.major}',
},
{'entity': target_sat.api.PartitionTable(), 'entity_type': 'ptable'},
{'entity': target_sat.api.Role()},
{'entity': target_sat.api.Role(), 'entity_type': 'role'},
{
'entity': target_sat.api.Subnet(),
'entity_type': 'subnet',
'value_template': '{entity.name} ({entity.network}/{entity.cidr})',
},
{'entity': target_sat.api.ProvisioningTemplate(), 'entity_type': 'provisioning_template'},
{'entity': target_sat.api.User(), 'value_template': '{entity.login}'},
{'entity': target_sat.api.UserGroup()},
{
'entity': target_sat.api.User(),
'value_template': '{entity.login}',
'entity_type': 'user',
},
{'entity': target_sat.api.UserGroup(), 'entity_type': 'usergroup'},
{'entity': target_sat.api.ContentView(), 'entity_type': 'katello/content_view'},
{'entity': target_sat.api.LifecycleEnvironment(), 'entity_type': 'katello/kt_environment'},
{'entity': target_sat.api.ActivationKey(), 'entity_type': 'katello/activation_key'},
Expand All @@ -85,10 +91,11 @@ def test_positive_create_by_type(target_sat):
},
]:
created_entity = entity_item['entity'].create()
entity_type = entity_item.get('entity_type', created_entity.__class__.__name__.lower())
value_template = entity_item.get('value_template', '{entity.name}')
entity_value = value_template.format(entity=created_entity)
audits = target_sat.api.Audit().search(query={'search': f'type={entity_type}'})
audits = target_sat.api.Audit().search(
query={'search': f'type={entity_item["entity_type"]}'}
)
entity_audits = [entry for entry in audits if entry.auditable_name == entity_value]
assert entity_audits, (
f'audit not found by name "{entity_value}" for entity: '
Expand All @@ -113,21 +120,19 @@ def test_positive_update_by_type(target_sat):
:CaseImportance: Medium
"""
for entity in [
target_sat.api.Architecture(),
target_sat.api.Domain(),
target_sat.api.HostGroup(),
target_sat.api.Location(),
target_sat.api.Role(),
target_sat.api.UserGroup(),
{'entity': target_sat.api.Architecture(), 'entity_type': 'architecture'},
{'entity': target_sat.api.Domain(), 'entity_type': 'domain'},
{'entity': target_sat.api.HostGroup(), 'entity_type': 'hostgroup'},
{'entity': target_sat.api.Location(), 'entity_type': 'location'},
{'entity': target_sat.api.Role(), 'entity_type': 'role'},
{'entity': target_sat.api.UserGroup(), 'entity_type': 'usergroup'},
]:
created_entity = entity.create()
created_entity = entity['entity'].create()
name = created_entity.name
new_name = gen_string('alpha')
created_entity.name = new_name
created_entity = created_entity.update(['name'])
audits = target_sat.api.Audit().search(
query={'search': f'type={created_entity.__class__.__name__.lower()}'}
)
audits = target_sat.api.Audit().search(query={'search': f'type={entity["entity_type"]}'})
entity_audits = [entry for entry in audits if entry.auditable_name == name]
assert entity_audits, f'audit not found by name "{name}"'
audit = entity_audits[0]
Expand All @@ -150,19 +155,16 @@ def test_positive_delete_by_type(target_sat):
:CaseImportance: Medium
"""
for entity in [
target_sat.api.Architecture(),
target_sat.api.Domain(),
target_sat.api.Host(),
target_sat.api.HostGroup(),
target_sat.api.Location(),
target_sat.api.Role(),
target_sat.api.UserGroup(),
{'entity': target_sat.api.Architecture(), 'entity_type': 'architecture'},
{'entity': target_sat.api.Domain(), 'entity_type': 'domain'},
{'entity': target_sat.api.HostGroup(), 'entity_type': 'hostgroup'},
{'entity': target_sat.api.Location(), 'entity_type': 'location'},
{'entity': target_sat.api.Role(), 'entity_type': 'role'},
{'entity': target_sat.api.UserGroup(), 'entity_type': 'usergroup'},
]:
created_entity = entity.create()
created_entity = entity['entity'].create()
created_entity.delete()
audits = target_sat.api.Audit().search(
query={'search': f'type={created_entity.__class__.__name__.lower()}'}
)
audits = target_sat.api.Audit().search(query={'search': f'type={entity["entity_type"]}'})
entity_audits = [entry for entry in audits if entry.auditable_name == created_entity.name]
assert entity_audits, f'audit not found by name "{created_entity.name}"'
audit = entity_audits[0]
Expand Down

0 comments on commit 0ed4dc7

Please sign in to comment.