Skip to content

Commit

Permalink
Filter test collection based on files changed in upstream PRs (#14931)
Browse files Browse the repository at this point in the history
  • Loading branch information
tpapaioa committed May 9, 2024
1 parent 67110bf commit 15d11d8
Show file tree
Hide file tree
Showing 5 changed files with 121 additions and 0 deletions.
16 changes: 16 additions & 0 deletions conf/github_repos.yaml.template
Original file line number Diff line number Diff line change
@@ -0,0 +1,16 @@
GITHUB_REPOS:
BASE_MARKER:
FOREMAN:
ORG: theforeman
REPO: foreman
RULES:
- PATH:
MARKER:
MARKER_ARG:
KATELLO:
ORG: Katello
REPO: katello
RULES:
- PATH:
MARKER:
MARKER_ARG:
1 change: 1 addition & 0 deletions conftest.py
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@
'pytest_plugins.sanity_plugin',
'pytest_plugins.video_cleanup',
'pytest_plugins.capsule_n-minus',
'pytest_plugins.upstream_pr',
# Fixtures
'pytest_fixtures.core.broker',
'pytest_fixtures.core.sat_cap_factory',
Expand Down
94 changes: 94 additions & 0 deletions pytest_plugins/upstream_pr.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,94 @@
from github import Github

from robottelo.config import settings
from robottelo.logging import collection_logger as logger


def rule_match(item, rules):
"""Return True if `item` has a marker matching one of the `rules`.
In order for a rule to match:
1. If `settings.github_repos.base_marker` exists, then `item` has a marker with the given value
as its `name` attribute.
2. `item` has a marker with the name given in `rule.marker`.
3. If `rule.marker_arg` exists, then the item's marker must also have the given value in marker's
`args` attribute.
"""
base_marker = settings.github_repos.get('base_marker')
return (
not base_marker or any(base_marker == marker.name for marker in item.iter_markers())
) and any(
rule.marker == marker.name
and (not rule.get('marker_arg') or rule.get('marker_arg') in marker.args)
for marker in item.iter_markers()
for rule in rules
)


def pytest_addoption(parser):
"""Add CLI option to specify upstream GitHub PRs.
Add --upstream-pr option for filtering tests based on the files modified by upstream
PRs.
"""
parser.addoption(
"--upstream-pr",
help=(
"Comma separated list of upstream PRs to filter test collection based on files modified in upstream.\n"
"Usage: `pytest tests/foreman --upstream-pr foreman/10146`"
),
)


def pytest_collection_modifyitems(session, items, config):
"""Filter tests based on upstream PRs.
1. Get the list of modified files in the upstream PRs.
2. Map each file to at most one marker.
3. Filter the collected tests to include only those with matching markers.
Note:
If no rules were matched above, all tests will be deselected. Any unprocessed filenames
(not matching any rules) are ignored.
"""
upstream_prs = [
pr_info for pr_info in (config.getoption('upstream_pr') or '').split(',') if pr_info != ''
]
if not upstream_prs:
return

matched_rules = []
for pr_info in upstream_prs:
# Get all filenames modified by this PR
repo_key, pr_id = pr_info.split('/')
if not (repo_config := settings.github_repos.get(repo_key)):
raise Exception(f"Key {repo_key} not found in settings file.")
pr = Github().get_repo(f"{repo_config.org}/{repo_config.repo}").get_pull(int(pr_id))
pr_filenames = {file.filename for commit in pr.get_commits() for file in commit.files}

# Get a list of matching rules
unprocessed_filenames = pr_filenames.copy()
for rule in repo_config.rules:
if matched_filenames := {
filename for filename in unprocessed_filenames if filename.startswith(rule.path)
}:
matched_rules.append(rule)
unprocessed_filenames.difference_update(matched_filenames)

# If no rules were matched above, deselect all tests.
# Any unprocessed filenames are ignored.
selected = []
deselected = []
for item in items:
if matched_rules:
if rule_match(item, matched_rules):
selected.append(item)
else:
logger.debug(f'Deselected test {item.nodeid} due to PR filter {upstream_prs}')
deselected.append(item)
else:
logger.debug(f'Deselected test {item.nodeid} due to PR filter {upstream_prs}')
deselected.append(item)

config.hook.pytest_deselected(items=deselected)
items[:] = selected
1 change: 1 addition & 0 deletions requirements.txt
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ jinja2==3.1.4
manifester==0.0.14
navmazing==1.2.2
productmd==1.38
PyGithub==2.3.0
pyotp==2.9.0
python-box==7.1.1
pytest==8.2.0
Expand Down
9 changes: 9 additions & 0 deletions robottelo/config/validators.py
Original file line number Diff line number Diff line change
Expand Up @@ -164,6 +164,15 @@
must_exist=True,
),
],
github_repos=[
Validator('github_repos.base_marker', default=None),
Validator('github_repos.foreman.org', default='theforeman'),
Validator('github_repos.foreman.repo', default='foreman'),
Validator('github_repos.foreman.rules', default=[], is_type_of=list),
Validator('github_repos.katello.org', default='Katello'),
Validator('github_repos.katello.repo', default='katello'),
Validator('github_repos.katello.rules', default=[], is_type_of=list),
],
http_proxy=[
Validator(
'http_proxy.un_auth_proxy_url',
Expand Down

0 comments on commit 15d11d8

Please sign in to comment.