PR checks without vault login

SatelliteQE · Sep 14, 2023 · 80ba020 · 80ba020
1 parent f328479
commit 80ba020
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 1 deletion.
diff --git a/.github/workflows/pull_request.yml b/.github/workflows/pull_request.yml
@@ -40,6 +40,8 @@ jobs:
           for conffile in conf/*.yaml.template; do mv -- "$conffile" "${conffile%.yaml.template}.yaml"; done
           cp broker_settings.yaml.example broker_settings.yaml
           cp .env.example .env
+          # To skip vault login in pull request checks
+          sed 's/^#\s*VAULT_SECRET_ID_FOR_DYNACONF=/VAULT_SECRET_ID_FOR_DYNACONF=somesecret/' .env
 
       - name: Pre Commit Checks
         uses: pre-commit/[email protected]

diff --git a/robottelo/utils/vault.py b/robottelo/utils/vault.py
@@ -61,7 +61,7 @@ def exec_vault_command(self, command: str, **kwargs):
     def login(self, **kwargs):
         if (
             re.search(r'\s*#.*VAULT_SECRET_ID_FOR_DYNACONF', self.env_path.read_text())
-            and 'VAULT_SECRET_ID_FOR_DYNACONF' not in os.environ
+            or 'VAULT_SECRET_ID_FOR_DYNACONF' not in os.environ
         ):
             if self.status(**kwargs).returncode != 0:
                 logger.warning(