fixed sanity suite, AttributeError due to not matching scope (#14309)

(cherry picked from commit 063ac02)

robottelo/host_helpers/satellite_mixins.py

@@ -144,10 +144,8 @@ def upload_manifest(self, org_id, manifest=None, interface='API', timeout=None):
         :returns: the manifest upload result
 
         """
-        if (
-            not isinstance(manifest, bytes | io.BytesIO)
-            and not hasattr(manifest, 'content')
-            or manifest.content is None
+        if not isinstance(manifest, bytes | io.BytesIO) and (
+            not hasattr(manifest, 'content') or manifest.content is None
         ):
             manifest = clone()
         if timeout is None:

tests/foreman/api/test_errata.py

@@ -34,7 +34,9 @@
 
 @pytest.fixture(scope='module')
 def activation_key(module_org, module_lce, module_target_sat):
-    module_target_sat.api.ActivationKey(environment=module_lce, organization=module_org).create()
+    return module_target_sat.api.ActivationKey(
+        environment=module_lce, organization=module_org
+    ).create()
 
 
 @pytest.fixture(scope='module')

tests/foreman/cli/test_satellitesync.py

@@ -151,7 +151,7 @@ def function_synced_rh_repo(request, target_sat, function_sca_manifest_org):
     # Update the download policy to 'immediate' and sync
     target_sat.cli.Repository.update({'download-policy': 'immediate', 'id': repo['id']})
     target_sat.cli.Repository.synchronize({'id': repo['id']}, timeout=7200000)
-    repo = target_sat.cli.Repository.info(
+    return target_sat.cli.Repository.info(
         {
             'organization-id': function_sca_manifest_org.id,
             'name': repo_dict['name'],

tests/foreman/longrun/test_inc_updates.py

@@ -54,7 +54,7 @@ def dev_lce(module_entitlement_manifest_org):
 
 @pytest.fixture(scope='module')
 def qe_lce(module_entitlement_manifest_org, dev_lce):
-    entities.LifecycleEnvironment(
+    return entities.LifecycleEnvironment(
         name='QE', prior=dev_lce, organization=module_entitlement_manifest_org
     ).create()