Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

REPO_TYPE ansible_collection seems to be wrong #13921

Closed
dosas opened this issue Jan 29, 2024 · 1 comment · Fixed by #13980
Closed

REPO_TYPE ansible_collection seems to be wrong #13921

dosas opened this issue Jan 29, 2024 · 1 comment · Fixed by #13980
Assignees
Labels
TestFailure Issues and PRs related to a test failing in automation

Comments

@dosas
Copy link
Collaborator

dosas commented Jan 29, 2024

@vsedmik I wonder if this change is correct

'ansible collection' -> 'ansible_collection'

Since katello replaces every underscore with a space.

@vsedmik vsedmik self-assigned this Feb 2, 2024
@vsedmik vsedmik added the TestFailure Issues and PRs related to a test failing in automation label Feb 2, 2024
@vsedmik
Copy link
Contributor

vsedmik commented Feb 2, 2024

Hello @dosas !

In that change I considered the constant was mostly used in CLI and API factory and repository_mixins and tests, where the correct value is really ansible_collection.

However, I can see your point. In UI it is really called ansible collection, so my change has obviously broken this singe test, where the constant is used too. I will raise a PR to fix this.

Thank you for the heads up, appreciated!

@vsedmik vsedmik linked a pull request Feb 2, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
TestFailure Issues and PRs related to a test failing in automation
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants