Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix UI AC repo test #13980

Merged
merged 1 commit into from
Feb 5, 2024
Merged

Fix UI AC repo test #13980

merged 1 commit into from
Feb 5, 2024

Conversation

vsedmik
Copy link
Contributor

@vsedmik vsedmik commented Feb 2, 2024

Problem Statement

It seems I have broken one UI test in #13068 by this change since CLI/API use it with _ but UI does not.

Solution

Just replace the _ in test. I think that defining new "UI only" constant would be even uglier.

Closing #13921

@vsedmik vsedmik added TestFailure Issues and PRs related to a test failing in automation Easy Fix :) Easiest Fix to review and quick merge request. CherryPick PR needs CherryPick to previous branches AutoMerge_Cherry_Picked The cherrypicked PRs of master PR would be automerged if all checks passing 6.15.z Introduced in or relating directly to Satellite 6.15 labels Feb 2, 2024
@vsedmik vsedmik requested a review from dosas February 2, 2024 15:19
@vsedmik vsedmik self-assigned this Feb 2, 2024
@vsedmik vsedmik requested a review from a team as a code owner February 2, 2024 15:19
@vsedmik
Copy link
Contributor Author

vsedmik commented Feb 2, 2024

trigger: test-robottelo
pytest: tests/foreman/ui/test_repository.py -k sync_ansible_collection_gallaxy_repo

@vsedmik vsedmik linked an issue Feb 2, 2024 that may be closed by this pull request
REPO_TYPE ansible_collection seems to be wrong #13921
Closed
@pondrejk pondrejk merged commit 3c5ba75 into SatelliteQE:master Feb 5, 2024
11 checks passed
github-actions bot pushed a commit that referenced this pull request Feb 5, 2024
@vsedmik @web-flow
Fix UI AC repo test (#13980)
099fff9 
(cherry picked from commit 3c5ba75)
@Satellite-QE Satellite-QE mentioned this pull request Feb 5, 2024
Merged
shweta83 pushed a commit to shweta83/robottelo that referenced this pull request Apr 10, 2024
@vsedmik @shweta83
Fix UI AC repo test (SatelliteQE#13980)
5de6ddf
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pondrejk pondrejk pondrejk approved these changes

@dosas dosas dosas approved these changes

Assignees

@vsedmik vsedmik

Labels
6.15.z Introduced in or relating directly to Satellite 6.15 AutoMerge_Cherry_Picked The cherrypicked PRs of master PR would be automerged if all checks passing CherryPick PR needs CherryPick to previous branches Easy Fix :) Easiest Fix to review and quick merge request. TestFailure Issues and PRs related to a test failing in automation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

REPO_TYPE ansible_collection seems to be wrong
3 participants
@vsedmik @dosas @pondrejk