Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Audit - Adding coverage for Discovery provisioning via CLI #12467

Merged
merged 2 commits into from
Oct 6, 2023
Merged

Audit - Adding coverage for Discovery provisioning via CLI #12467

merged 2 commits into from
Oct 6, 2023

Conversation

adarshdubey-star
Copy link
Contributor

PR aims to add coverage for Pxe and Pxeless Discovery host provisioning via hammer(CLI).

@adarshdubey-star adarshdubey-star added QETestCoverage Issues and PRs relating to a Satellite bug CherryPick PR needs CherryPick to previous branches 6.13.z Introduced in or relating directly to Satellite 6.13 6.14.z Introduced in or relating directly to Satellite 6.14 labels Sep 4, 2023
@adarshdubey-star adarshdubey-star self-assigned this Sep 4, 2023
@adarshdubey-star adarshdubey-star requested review from a team as code owners September 4, 2023 13:55
@adarshdubey-star adarshdubey-star marked this pull request as draft September 4, 2023 13:55
@adarshdubey-star
Copy link
Contributor Author 


trigger: test-robottelo
pytest: tests/foreman/cli/test_discoveredhost.py
provisioning: true
env:
    ROBOTTELO_server__deploy_arguments__deploy_sat_version: '6.13.4'
    ROBOTTELO_server__deploy_arguments__deploy_snap_version: '1.0'

@adarshdubey-star adarshdubey-star force-pushed the discovery_3 branch 2 times, most recently from 68b2352 to 3db1663 Compare September 6, 2023 06:20
@adarshdubey-star
Copy link
Contributor Author 

trigger: test-robottelo
pytest: tests/foreman/cli/test_discoveredhost.py
provisioning: true
env:
    ROBOTTELO_server__deploy_arguments__deploy_sat_version: '6.14.0'
    ROBOTTELO_server__deploy_arguments__deploy_snap_version: '14.0'

@adarshdubey-star adarshdubey-star force-pushed the discovery_3 branch 2 times, most recently from 876bf26 to e075a74 Compare September 14, 2023 05:37
@adarshdubey-star adarshdubey-star force-pushed the discovery_3 branch 2 times, most recently from 7c6f08b to 86a142a Compare September 20, 2023 17:31
@adarshdubey-star
Copy link
Contributor Author

trigger: test-robottelo
pytest: tests/foreman/cli/test_discoveredhost.py -k test_positive_provision_pxe_host_cli
provisioning: true

@adarshdubey-star adarshdubey-star marked this pull request as ready for review September 20, 2023 18:30
Griffin-Sullivan
Griffin-Sullivan approved these changes Sep 22, 2023
View reviewed changes
Copy link
Contributor

@Griffin-Sullivan Griffin-Sullivan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work. I see PRT passed for pxe-based. Do we have results for pxeless?

@adarshdubey-star
Copy link
Contributor Author

Nice work. I see PRT passed for pxe-based. Do we have results for pxeless?

Yeah, we had a BZ filed for the pxe less scenario, retriggering PRT as the BZ is delivered.

@adarshdubey-star
Copy link
Contributor Author

trigger: test-robottelo
pytest: tests/foreman/cli/test_discoveredhost.py
provisioning: true

2 similar comments
@adarshdubey-star
Copy link
Contributor Author

trigger: test-robottelo
pytest: tests/foreman/cli/test_discoveredhost.py
provisioning: true

@adarshdubey-star
Copy link
Contributor Author

trigger: test-robottelo
pytest: tests/foreman/cli/test_discoveredhost.py
provisioning: true

@adarshdubey-star
Copy link
Contributor Author

trigger: test-robottelo
pytest: tests/foreman/cli/test_discoveredhost.py -k test_positive_provision_pxe_less_host_cli
provisioning: true

@adarshdubey-star
Copy link
Contributor Author 

trigger: test-robottelo
pytest: tests/foreman/cli/test_discoveredhost.py
provisioning: true
env:
    ROBOTTELO_server__deploy_arguments__deploy_sat_version: '6.14.0'
    ROBOTTELO_server__deploy_arguments__deploy_snap_version: '17.0'

@adarshdubey-star
Copy link
Contributor Author

adarshdubey-star commented Sep 26, 2023 •
edited
Loading

The FDI package is not updated in the stream which was causing the PRT failure, on 6.14 it is green.

shubhamsg199
shubhamsg199 approved these changes Sep 26, 2023
View reviewed changes
Copy link
Contributor

@shubhamsg199 shubhamsg199 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

Gauravtalreja1
Gauravtalreja1 reviewed Sep 30, 2023
View reviewed changes
@adarshdubey-star
Copy link
Contributor Author 

trigger: test-robottelo
pytest: tests/foreman/cli/test_discoveredhost.py
provisioning: true
env:
    ROBOTTELO_server__deploy_arguments__deploy_sat_version: '6.14.0'
    ROBOTTELO_server__deploy_arguments__deploy_snap_version: '19.0'

@adarshdubey-star
Copy link
Contributor Author 

trigger: test-robottelo
pytest: tests/foreman/cli/test_discoveredhost.py
provisioning: true
env:
    ROBOTTELO_server__deploy_arguments__deploy_sat_version: '6.14.0'
    ROBOTTELO_server__deploy_arguments__deploy_snap_version: '19.0'

@adarshdubey-star
Copy link
Contributor Author 

trigger: test-robottelo
pytest: tests/foreman/cli/test_discoveredhost.py
provisioning: true
env:
    ROBOTTELO_server__deploy_arguments__deploy_sat_version: '6.14.0'
    ROBOTTELO_server__deploy_arguments__deploy_snap_version: '19.0'

2 similar comments
@adarshdubey-star
Copy link
Contributor Author 

trigger: test-robottelo
pytest: tests/foreman/cli/test_discoveredhost.py
provisioning: true
env:
    ROBOTTELO_server__deploy_arguments__deploy_sat_version: '6.14.0'
    ROBOTTELO_server__deploy_arguments__deploy_snap_version: '19.0'

@adarshdubey-star
Copy link
Contributor Author 

trigger: test-robottelo
pytest: tests/foreman/cli/test_discoveredhost.py
provisioning: true
env:
    ROBOTTELO_server__deploy_arguments__deploy_sat_version: '6.14.0'
    ROBOTTELO_server__deploy_arguments__deploy_snap_version: '19.0'

@Gauravtalreja1
Copy link
Collaborator 

trigger: test-robottelo
pytest: tests/foreman/cli/test_discoveredhost.py
provisioning: true
env:
    ROBOTTELO_server__deploy_arguments__deploy_sat_version: '6.14.0'
    ROBOTTELO_server__deploy_arguments__deploy_snap_version: '19.0'

@Gauravtalreja1 Gauravtalreja1 added AutoMerge_Cherry_Picked The cherrypicked PRs of master PR would be automerged if all checks passing 6.12.z Introduced in or relating directly to Satellite 6.12 labels Oct 5, 2023
@adarshdubey-star
Copy link
Contributor Author 

trigger: test-robottelo
pytest: tests/foreman/cli/test_discoveredhost.py
provisioning: true
env:
    ROBOTTELO_server__deploy_arguments__deploy_sat_version: '6.14.0'
    ROBOTTELO_server__deploy_arguments__deploy_snap_version: '19.0'

Gauravtalreja1
Gauravtalreja1 approved these changes Oct 6, 2023
View reviewed changes
Copy link
Collaborator

@Gauravtalreja1 Gauravtalreja1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK, @adarshdubey-star Great job on this, thank you!

@Gauravtalreja1 Gauravtalreja1 merged commit 272a3aa into SatelliteQE:master Oct 6, 2023
@Satellite-QE Satellite-QE mentioned this pull request Oct 6, 2023
Merged
github-actions bot pushed a commit that referenced this pull request Oct 6, 2023
@adarshdubey-star @web-flow
Audit - Adding coverage for Discovery provisioning via CLI (#12467)
e5aad93 
* Adding coverage for Discovery provisioning via CLI

Signed-off-by: Adarsh Dubey <[email protected]>

* Adding finalizer

---------

Signed-off-by: Adarsh Dubey <[email protected]>
(cherry picked from commit 272a3aa)
@Satellite-QE Satellite-QE mentioned this pull request Oct 6, 2023
Closed
github-actions bot pushed a commit that referenced this pull request Oct 6, 2023
@adarshdubey-star @web-flow
Audit - Adding coverage for Discovery provisioning via CLI (#12467)
c8b8abd 
* Adding coverage for Discovery provisioning via CLI

Signed-off-by: Adarsh Dubey <[email protected]>

* Adding finalizer

---------

Signed-off-by: Adarsh Dubey <[email protected]>
(cherry picked from commit 272a3aa)
@Satellite-QE Satellite-QE mentioned this pull request Oct 6, 2023
Merged
github-actions bot pushed a commit that referenced this pull request Oct 6, 2023
@adarshdubey-star @web-flow
Audit - Adding coverage for Discovery provisioning via CLI (#12467)
d462716 
* Adding coverage for Discovery provisioning via CLI

Signed-off-by: Adarsh Dubey <[email protected]>

* Adding finalizer

---------

Signed-off-by: Adarsh Dubey <[email protected]>
(cherry picked from commit 272a3aa)
Gauravtalreja1 pushed a commit that referenced this pull request Oct 6, 2023
@Satellite-QE @adarshdubey-star
[6.14.z] Audit - Adding coverage for Discovery provisioning via CLI (#…
df3a5ae 
…12826)

Audit - Adding coverage for Discovery provisioning via CLI (#12467)

* Adding coverage for Discovery provisioning via CLI

Signed-off-by: Adarsh Dubey <[email protected]>

* Adding finalizer

---------

Signed-off-by: Adarsh Dubey <[email protected]>
(cherry picked from commit 272a3aa)

Co-authored-by: Adarsh dubey <[email protected]>
Gauravtalreja1 pushed a commit that referenced this pull request Oct 6, 2023
@Satellite-QE @adarshdubey-star
[6.13.z] Audit - Adding coverage for Discovery provisioning via CLI (#…
3813814 
…12828)

Audit - Adding coverage for Discovery provisioning via CLI (#12467)

* Adding coverage for Discovery provisioning via CLI

Signed-off-by: Adarsh Dubey <[email protected]>

* Adding finalizer

---------

Signed-off-by: Adarsh Dubey <[email protected]>
(cherry picked from commit 272a3aa)

Co-authored-by: Adarsh dubey <[email protected]>
Gauravtalreja1 pushed a commit that referenced this pull request Oct 7, 2023
@adarshdubey-star @Gauravtalreja1
Audit - Adding coverage for Discovery provisioning via CLI (#12467)
aa3d7ff 
* Adding coverage for Discovery provisioning via CLI

Signed-off-by: Adarsh Dubey <[email protected]>

* Adding finalizer

---------

Signed-off-by: Adarsh Dubey <[email protected]>
(cherry picked from commit 272a3aa)
ColeHiggins2 pushed a commit to ColeHiggins2/robottelo that referenced this pull request Oct 9, 2023
@adarshdubey-star @ColeHiggins2
Audit - Adding coverage for Discovery provisioning via CLI (Satellite…
6350fe1 
…QE#12467)

* Adding coverage for Discovery provisioning via CLI

Signed-off-by: Adarsh Dubey <[email protected]>

* Adding finalizer

---------

Signed-off-by: Adarsh Dubey <[email protected]>
damoore044 pushed a commit to damoore044/robottelo that referenced this pull request Oct 10, 2023
@adarshdubey-star @damoore044
Audit - Adding coverage for Discovery provisioning via CLI (Satellite…
57ff264 
…QE#12467)

* Adding coverage for Discovery provisioning via CLI

Signed-off-by: Adarsh Dubey <[email protected]>

* Adding finalizer

---------

Signed-off-by: Adarsh Dubey <[email protected]>
jyejare pushed a commit that referenced this pull request Jan 2, 2024
@adarshdubey-star @jyejare
Audit - Adding coverage for Discovery provisioning via CLI (#12467)
d1a4b37 
* Adding coverage for Discovery provisioning via CLI

Signed-off-by: Adarsh Dubey <[email protected]>

* Adding finalizer

---------

Signed-off-by: Adarsh Dubey <[email protected]>
(cherry picked from commit 272a3aa)
shweta83 pushed a commit to shweta83/robottelo that referenced this pull request Apr 10, 2024
@adarshdubey-star @shweta83
Audit - Adding coverage for Discovery provisioning via CLI (Satellite…
c6f3f59 
…QE#12467)

* Adding coverage for Discovery provisioning via CLI

Signed-off-by: Adarsh Dubey <[email protected]>

* Adding finalizer

---------

Signed-off-by: Adarsh Dubey <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Gauravtalreja1 Gauravtalreja1 Gauravtalreja1 approved these changes

@Griffin-Sullivan Griffin-Sullivan Griffin-Sullivan approved these changes

@shubhamsg199 shubhamsg199 shubhamsg199 approved these changes

Assignees

@adarshdubey-star adarshdubey-star

Labels
6.12.z Introduced in or relating directly to Satellite 6.12 6.13.z Introduced in or relating directly to Satellite 6.13 6.14.z Introduced in or relating directly to Satellite 6.14 AutoMerge_Cherry_Picked The cherrypicked PRs of master PR would be automerged if all checks passing CherryPick PR needs CherryPick to previous branches QETestCoverage Issues and PRs relating to a Satellite bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@adarshdubey-star @Gauravtalreja1 @Griffin-Sullivan @shubhamsg199