Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Component Audit Part-2 #12519

Merged
merged 1 commit into from
Nov 21, 2023
Merged

Component Audit Part-2 #12519

merged 1 commit into from
Nov 21, 2023

Conversation

shweta83
Copy link
Contributor

@shweta83 shweta83 commented Sep 7, 2023

This PR is Part-2 of Component Audit and it will have following test case additions:

  1. test_positive_update_packages_post_registration
  2. test_positive_host_registration_with_non_admin_user

@shweta83 shweta83 requested a review from a team as a code owner September 7, 2023 06:23
@shweta83 shweta83 added CherryPick PR needs CherryPick to previous branches AutoMerge_Cherry_Picked The cherrypicked PRs of master PR would be automerged if all checks passing 6.13.z Introduced in or relating directly to Satellite 6.13 6.14.z Introduced in or relating directly to Satellite 6.14 labels Sep 7, 2023
Gauravtalreja1
Gauravtalreja1 reviewed Sep 7, 2023
View reviewed changes
tests/foreman/api/test_registration.py Show resolved Hide resolved
tests/foreman/api/test_registration.py Outdated Show resolved Hide resolved
tests/foreman/api/test_registration.py Outdated Show resolved Hide resolved
tests/foreman/ui/test_host.py Outdated Show resolved Hide resolved
@Gauravtalreja1
Copy link
Collaborator

@shweta83 Can you update this PR?

@shweta83 shweta83 force-pushed the Component_Audit_Part2 branch from 84d9936 to 072012b Compare November 8, 2023 07:48
@shweta83 shweta83 requested a review from a team as a code owner November 8, 2023 07:48
shubhamsg199
shubhamsg199 reviewed Nov 16, 2023
View reviewed changes
tests/foreman/api/test_registration.py Show resolved Hide resolved
tests/foreman/api/test_registration.py Outdated Show resolved Hide resolved
tests/foreman/api/test_registration.py Show resolved Hide resolved
tests/foreman/ui/test_host.py Outdated Show resolved Hide resolved
tests/foreman/ui/test_host.py Show resolved Hide resolved
tests/foreman/ui/test_host.py Show resolved Hide resolved
adarshdubey-star
adarshdubey-star approved these changes Nov 17, 2023
View reviewed changes
Copy link
Contributor

@adarshdubey-star adarshdubey-star left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM , Let's have a PRT run as well

Gauravtalreja1
Gauravtalreja1 reviewed Nov 17, 2023
View reviewed changes
tests/foreman/ui/test_host.py Outdated Show resolved Hide resolved
tests/foreman/api/test_registration.py Outdated Show resolved Hide resolved
pytest_fixtures/component/activationkey.py Show resolved Hide resolved
tests/foreman/api/test_registration.py Outdated Show resolved Hide resolved
tests/foreman/ui/test_host.py Outdated Show resolved Hide resolved
tests/foreman/ui/test_host.py Outdated Show resolved Hide resolved
tests/foreman/ui/test_host.py Outdated Show resolved Hide resolved
@shweta83 shweta83 force-pushed the Component_Audit_Part2 branch 3 times, most recently from fe05f7e to ece3411 Compare November 21, 2023 14:11
@shweta83
Copy link
Contributor Author

trigger: test-robottelo
pytest: tests/foreman/api/test_registration.py -k test_positive_update_packages_post_registration

@shweta83 shweta83 force-pushed the Component_Audit_Part2 branch 2 times, most recently from 906e56b to 96c22fb Compare November 21, 2023 14:45
@shweta83 shweta83 force-pushed the Component_Audit_Part2 branch from 96c22fb to 864cc45 Compare November 21, 2023 14:46
@shweta83
Copy link
Contributor Author

trigger: test-robottelo
pytest: tests/foreman/api/test_registration.py -k test_positive_update_packages_post_registration

1 similar comment
@shweta83
Copy link
Contributor Author

trigger: test-robottelo
pytest: tests/foreman/api/test_registration.py -k test_positive_update_packages_post_registration

@shweta83
Copy link
Contributor Author

trigger: test-robottelo
pytest: tests/foreman/api/test_registration.py -k test_positive_update_packages_registration

@shweta83 shweta83 added the 6.12.z Introduced in or relating directly to Satellite 6.12 label Nov 21, 2023
@Gauravtalreja1 Gauravtalreja1 added QETestCoverage Issues and PRs relating to a Satellite bug and removed 6.12.z Introduced in or relating directly to Satellite 6.12 labels Nov 21, 2023
@Gauravtalreja1 Gauravtalreja1 added the 6.12.z Introduced in or relating directly to Satellite 6.12 label Nov 21, 2023
@Gauravtalreja1 Gauravtalreja1 merged commit 2e46f7e into SatelliteQE:master Nov 21, 2023
10 checks passed
This was referenced Nov 21, 2023
Closed
Closed
Closed
Gauravtalreja1 pushed a commit to Gauravtalreja1/robottelo that referenced this pull request Nov 22, 2023
@shweta83 @Gauravtalreja1
Component Audit Part-2 (SatelliteQE#12519)
b9ffef6 
(cherry picked from commit 2e46f7e)
Gauravtalreja1 pushed a commit to Gauravtalreja1/robottelo that referenced this pull request Nov 22, 2023
@shweta83 @Gauravtalreja1
Component Audit Part-2 (SatelliteQE#12519)
15bd38c 
(cherry picked from commit 2e46f7e)
adarshdubey-star pushed a commit that referenced this pull request Nov 22, 2023
@Gauravtalreja1 @shweta83
[6.13.z] Component Audit Part-2 (#13159)
7f5a56d 
Component Audit Part-2 (#12519)

(cherry picked from commit 2e46f7e)

Co-authored-by: Shweta Singh <[email protected]>
adarshdubey-star pushed a commit that referenced this pull request Nov 22, 2023
@Gauravtalreja1 @shweta83
[6.14.z] Component Audit Part-2 (#13158)
37e2147 
Component Audit Part-2 (#12519)

(cherry picked from commit 2e46f7e)

Co-authored-by: Shweta Singh <[email protected]>
shweta83 added a commit to shweta83/robottelo that referenced this pull request Apr 10, 2024
@shweta83
Component Audit Part-2 (SatelliteQE#12519)
77f3bee
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shubhamsg199 shubhamsg199 shubhamsg199 left review comments

@adarshdubey-star adarshdubey-star adarshdubey-star approved these changes

@Gauravtalreja1 Gauravtalreja1 Gauravtalreja1 approved these changes

Assignees

@shweta83 shweta83

Labels
6.12.z Introduced in or relating directly to Satellite 6.12 6.13.z Introduced in or relating directly to Satellite 6.13 6.14.z Introduced in or relating directly to Satellite 6.14 AutoMerge_Cherry_Picked The cherrypicked PRs of master PR would be automerged if all checks passing CherryPick PR needs CherryPick to previous branches QETestCoverage Issues and PRs relating to a Satellite bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@shweta83 @Gauravtalreja1 @adarshdubey-star @shubhamsg199