PRT comment adding using curl more standard way #12521
Conversation
omkarkhatavkar
added
CherryPick
| repo-token: ${{ secrets.CHERRYPICK_PAT }} | ||
| run: | | ||
| ISSUE_NUMBER=${{ steps.cherrypick.outputs.number }} | ||
| GITHUB_TOKEN="${{ secrets.CHERRYPICK_PAT }}" |
There was a problem hiding this comment.
Not sure! But this must be overriding the default GITHUB_TOKEN comes from Github, if not or anyways its good to rename it just to avoid the confusion !
There was a problem hiding this comment.
@omkarkhatavkar Can you check this and update PR accordingly?
There was a problem hiding this comment.
@jyejare , @Gauravtalreja1 Yes, we are passing the "${{ secrets.CHERRYPICK_PAT }}" our own Satellie_user token, you know it why we need that if we use the GITHUB_TOKEN then the PR would have a comment from the GitHubAction user, while we are using Satellite user everywhere.
There was a problem hiding this comment.
@omkarkhatavkar I got that! I just wanted to reiterate that we could have named the GITHUB_TOKEN env var to something else for CHERRYPICK_PAT, cause this will actually override the GITHUB_TOKEN which in the feature you might want to use in this GHA.
I mean is the naming of env var here deliberate?
There was a problem hiding this comment.
I can directly pass the CHERRYPICK_PAT instead the variable as well. If that work for you ?
There was a problem hiding this comment.
@jyejare tested here https://github.com/omkarkhatavkar/robottelo/actions/runs/6693395618/job/18184437416?pr=158#step:2:1, token is not **** looks okay to me
omkarkhatavkar
force-pushed
the
comment_fix
branch
from
da61c5a to
9140baf
Compare
PRT comment adding using curl more standtard way
Moving away from github action to standard curl for handing the PRT comment