Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[6.13.z] Convert2Rhel test fixes #12522

Merged
merged 1 commit into from
Nov 1, 2023
Merged

[6.13.z] Convert2Rhel test fixes #12522

merged 1 commit into from
Nov 1, 2023

Conversation

Satellite-QE
Copy link
Collaborator

Cherrypick of PR: #10840

Fixed Convert2RHEL test failures.

@Satellite-QE Satellite-QE added 6.13.z Introduced in or relating directly to Satellite 6.13 Auto_Cherry_Picked Automatically cherrypicked PR using GHA No-CherryPick PR doesnt need CherryPick to previous branches labels Sep 7, 2023
@Satellite-QE
Copy link
Collaborator Author

trigger: test-robottelo
pytest: tests/foreman/api/test_convert2rhel.py -k test_convert2rhel_centos[centos7]

@Satellite-QE Satellite-QE added the AutoMerge_Cherry_Picked The cherrypicked PRs of master PR would be automerged if all checks passing label Sep 7, 2023
@omkarkhatavkar
Copy link

trigger: test-robottelo
pytest: tests/foreman/api/test_convert2rhel.py -k test_convert2rhel_centos[centos7]

@Gauravtalreja1
Copy link
Collaborator

@shweta83 Could you check the failing PRT?

@github-actions
Copy link

This pull request has not been updated in the past 45 days.

@github-actions github-actions bot added the Stale Stale issue or Pull Request label Oct 31, 2023
@shweta83 @Gauravtalreja1
Convert2Rhel test fixes (#10840)
3896863 
(cherry picked from commit 55b0800)
@Gauravtalreja1 Gauravtalreja1 force-pushed the cherry-pick-6.13.z-55b0800effd67331753d74aa423d20f749f2b630 branch from 6291dd7 to 3896863 Compare October 31, 2023 07:22
@Gauravtalreja1
Copy link
Collaborator

trigger: test-robottelo
pytest: tests/foreman/api/test_convert2rhel.py -k test_convert2rhel_centos

@github-actions github-actions bot removed the Stale Stale issue or Pull Request label Nov 1, 2023
Gauravtalreja1
Gauravtalreja1 approved these changes Nov 1, 2023
View reviewed changes
Copy link
Collaborator

@Gauravtalreja1 Gauravtalreja1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PRT failure looks unrelated atm, and looking at the changes it is solving the issue of checkout with s/vm.release/vm.deploy_rhel_version which works, so will merge this as is and PRT failures can be considered during TFA by @shweta83

@Gauravtalreja1 Gauravtalreja1 merged commit 55856d8 into 6.13.z Nov 1, 2023
5 checks passed
@Gauravtalreja1 Gauravtalreja1 deleted the cherry-pick-6.13.z-55b0800effd67331753d74aa423d20f749f2b630 branch November 1, 2023 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Gauravtalreja1 Gauravtalreja1 Gauravtalreja1 approved these changes

Assignees

@shweta83 shweta83

@Satellite-QE Satellite-QE

Labels
6.13.z Introduced in or relating directly to Satellite 6.13 Auto_Cherry_Picked Automatically cherrypicked PR using GHA AutoMerge_Cherry_Picked The cherrypicked PRs of master PR would be automerged if all checks passing No-CherryPick PR doesnt need CherryPick to previous branches
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Satellite-QE @omkarkhatavkar @Gauravtalreja1 @shweta83