Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Helpers Best Practices Guide #12556

Merged
merged 1 commit into from
Sep 22, 2023
Merged

Conversation

jyejare
Copy link
Member

@jyejare jyejare commented Sep 8, 2023

Helpers Best Practices Guide is here to help assist Contributors to write the helper in a write place according to its usage.

The Guide contains three main sections:

  1. General Practices
  2. Description of main helper modules in robottelo
  3. FAQs

@jyejare jyejare requested a review from a team as a code owner September 8, 2023 15:22
@jyejare jyejare added the No-CherryPick PR doesnt need CherryPick to previous branches label Sep 8, 2023
@adarshdubey-star
Copy link
Contributor

That is very well documented @jyejare.

@adarshdubey-star
Copy link
Contributor

I would suggest including something related to our conf files as they play an important role in the test execution and also the use of constants across Robottelo.

@jyejare
Copy link
Member Author

jyejare commented Sep 11, 2023

@adarshdubey-star That would be nice addition ! But probably they are not good candidates for helpers best practices guide !

This guide is solely to help finding existing helpers or to add new !

BEST_PRACTICES.md Outdated Show resolved Hide resolved
BEST_PRACTICES.md Outdated Show resolved Hide resolved
BEST_PRACTICES.md Outdated Show resolved Hide resolved
BEST_PRACTICES.md Outdated Show resolved Hide resolved
BEST_PRACTICES.md Outdated Show resolved Hide resolved
BEST_PRACTICES.md Outdated Show resolved Hide resolved
BEST_PRACTICES.md Outdated Show resolved Hide resolved
BEST_PRACTICES.md Outdated Show resolved Hide resolved
BEST_PRACTICES.md Outdated Show resolved Hide resolved
BEST_PRACTICES.md Outdated Show resolved Hide resolved
@jyejare
Copy link
Member Author

jyejare commented Sep 20, 2023

@JacobCallahan Resolved all your comments ! Thanks :)

@Gauravtalreja1 Gauravtalreja1 merged commit 27f1225 into SatelliteQE:master Sep 22, 2023
damoore044 pushed a commit to damoore044/robottelo that referenced this pull request Sep 22, 2023
damoore044 pushed a commit to damoore044/robottelo that referenced this pull request Oct 4, 2023
ColeHiggins2 pushed a commit to ColeHiggins2/robottelo that referenced this pull request Oct 9, 2023
damoore044 pushed a commit to damoore044/robottelo that referenced this pull request Oct 10, 2023
shweta83 pushed a commit to shweta83/robottelo that referenced this pull request Apr 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
No-CherryPick PR doesnt need CherryPick to previous branches
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants