Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hosts cockpit tests fix #12557

Closed

Conversation

pnovotny
Copy link
Contributor

@pnovotny pnovotny commented Sep 8, 2023

Use global registration for Cockipt host.

It shoud fix problem with repo setup & Cockpit installation.

@pnovotny pnovotny added CherryPick PR needs CherryPick to previous branches AutoMerge_Cherry_Picked The cherrypicked PRs of master PR would be automerged if all checks passing 6.14.z Introduced in or relating directly to Satellite 6.14 labels Sep 8, 2023
@pnovotny pnovotny self-assigned this Sep 8, 2023
@pnovotny pnovotny requested review from pondrejk, lhellebr and a team September 8, 2023 15:24
@pnovotny
Copy link
Contributor Author

pnovotny commented Sep 8, 2023

trigger: test-robottelo
pytest: tests/foreman/destructive/test_host.py -k test_positive_cockpit

Copy link
Contributor

@lhellebr lhellebr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking at the changes, they look sane, but in PRT:

    def test_positive_cockpit(self, cockpit_host, class_cockpit_sat, class_org):
        [...]
        with class_cockpit_sat.ui_session() as session:
            session.organization.select(org_name=class_org.name)
            session.location.select(loc_name=ANY_CONTEXT['location'])
            kill_process = class_cockpit_sat.execute('pkill -f cockpit-ws')
>           assert kill_process.status == 0
E           AssertionError: assert 1 == 0
E            +  where 1 = stdout:\n\nstderr:\n(0, b'')\nstatus: 1.status

Use global registration for `contenthosts::cockpit_host` fixture.

Also a minor logging message improvement.
@pnovotny pnovotny force-pushed the hosts-cockpit-tests-fix branch from dd08b2e to aa13454 Compare October 4, 2023 12:51
@pnovotny
Copy link
Contributor Author

pnovotny commented Oct 4, 2023

trigger: test-robottelo
pytest: tests/foreman/destructive/test_host.py -k test_positive_cockpit

@pnovotny
Copy link
Contributor Author

pnovotny commented Oct 4, 2023

Rebasing & re-running PRT. I see in ReportPortal that on with the latest 6.14. only rhel_7 host failed, the rest (rhel 8 & 9) is passing.

@pnovotny
Copy link
Contributor Author

pnovotny commented Oct 4, 2023

trigger: test-robottelo
pytest: tests/foreman/destructive/test_host.py -k test_positive_cockpit

Copy link

This pull request has not been updated in the past 45 days.

@github-actions github-actions bot added the Stale Stale issue or Pull Request label Nov 19, 2023
Copy link

This pull request is now being closed after stale warnings.

@github-actions github-actions bot closed this Nov 27, 2023
@pnovotny pnovotny deleted the hosts-cockpit-tests-fix branch April 30, 2024 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.14.z Introduced in or relating directly to Satellite 6.14 AutoMerge_Cherry_Picked The cherrypicked PRs of master PR would be automerged if all checks passing CherryPick PR needs CherryPick to previous branches Stale Stale issue or Pull Request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants