Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixing the memory issue in auto-cherry-pick GHA #12636

Merged
merged 1 commit into from
Sep 20, 2023

Conversation

omkarkhatavkar
Copy link

PR Description

Summary

This PR addresses an issue related to out-of-memory errors during the execution of GitHub Actions workflows. To mitigate this problem, we're introducing a step to set up swap space.

Changes Made

  • Added a new step to the workflow that sets up swap space with a size of 10GB.

Context

In certain resource-intensive workflows, such as those involving large builds or data processing tasks, GitHub Actions runners may encounter out-of-memory errors. These errors can disrupt the workflow and cause it to fail.

To avoid such errors and ensure the smooth execution of workflows, we have introduced a step that configures a swap space of 10GB. Swap space provides additional virtual memory, which can be used when the physical memory is exhausted, thereby preventing out-of-memory errors.

@omkarkhatavkar omkarkhatavkar requested a review from a team as a code owner September 15, 2023 13:01
@omkarkhatavkar omkarkhatavkar added CherryPick PR needs CherryPick to previous branches 6.12.z Introduced in or relating directly to Satellite 6.12 6.13.z Introduced in or relating directly to Satellite 6.13 6.14.z Introduced in or relating directly to Satellite 6.14 labels Sep 15, 2023
Copy link
Contributor

@synkd synkd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Non-blocking, but do we have a way to monitor whether runners are actively swapping when under memory pressure?

@omkarkhatavkar
Copy link
Author

omkarkhatavkar commented Sep 20, 2023

Non-blocking, but do we have a way to monitor whether runners are actively swapping when under memory pressure?

This will by default swap memory space and can be seen in the logs after we merge this https://github.com/pierotofy/set-swap-space/blob/master/action.yml#L32 line it shows after modification.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.12.z Introduced in or relating directly to Satellite 6.12 6.13.z Introduced in or relating directly to Satellite 6.13 6.14.z Introduced in or relating directly to Satellite 6.14 CherryPick PR needs CherryPick to previous branches
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants