Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[6.13.z] UI Utils module depreciation and new ui_factory module #12643

Merged
merged 1 commit into from
Sep 18, 2023
Merged

[6.13.z] UI Utils module depreciation and new ui_factory module #12643

merged 1 commit into from
Sep 18, 2023

Conversation

Satellite-QE
Copy link
Collaborator

Cherrypick of PR: #12225

  • Depreciating UI Utils module, removed UI utils file and package!
  • Introduced new ui_factory attribute to satellite class, returns the UIFactory class object containing all the UI Factory methods.
    So now this could be used as target_sat.ui_factory.ui_method()
  • Impacted test modules changed to use ui_factory methods.

@jyejare @web-flow
UI Utils module depreciation and new ui_factory module (#12225)
648a3a6 
Depreciation of UI Utils

(cherry picked from commit ab21023)
@Satellite-QE Satellite-QE added 6.13.z Introduced in or relating directly to Satellite 6.13 Auto_Cherry_Picked Automatically cherrypicked PR using GHA No-CherryPick PR doesnt need CherryPick to previous branches labels Sep 18, 2023
@Satellite-QE
Copy link
Collaborator Author

trigger: test-robottelo
pytest: tests/foreman/ui/test_reporttemplates.py -k test_positive_generate_registered_hosts_report

@jyejare
Copy link
Member

jyejare commented Sep 18, 2023

All checks are passing ! Merging !

@jyejare jyejare merged commit a7bf467 into 6.13.z Sep 18, 2023
2 checks passed
@jyejare jyejare deleted the cherry-pick-6.13.z-ab2102352e0137f7148448c764587f71df7ce1d3 branch September 18, 2023 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jyejare jyejare

@Satellite-QE Satellite-QE

Labels
6.13.z Introduced in or relating directly to Satellite 6.13 Auto_Cherry_Picked Automatically cherrypicked PR using GHA No-CherryPick PR doesnt need CherryPick to previous branches
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Satellite-QE @jyejare