Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ISS refactor - batch 3 #12651

Merged
merged 1 commit into from
Oct 31, 2023
Merged

ISS refactor - batch 3 #12651

merged 1 commit into from
Oct 31, 2023

Conversation

vsedmik
Copy link
Contributor

@vsedmik vsedmik commented Sep 19, 2023 •
edited
Loading

Based on #12347.

Introduced changes:

  1. Extended test_positive_import_content_for_disconnected_sat_with_existing_content by assertion for correct error message when non-import-only CV is used for import
  2. Removed _import_entities
  3. Added test for customer scenarios:
    test_postive_export_import_cv_with_long_name
    test_positive_export_rerun_failed_import
    test_postive_export_import_repo_with_GPG

@vsedmik vsedmik added CLI Issues and PRs involving the CLI CherryPick PR needs CherryPick to previous branches 6.12.z Introduced in or relating directly to Satellite 6.12 AutoMerge_Cherry_Picked The cherrypicked PRs of master PR would be automerged if all checks passing 6.13.z Introduced in or relating directly to Satellite 6.13 6.14.z Introduced in or relating directly to Satellite 6.14 labels Sep 19, 2023
@vsedmik vsedmik requested a review from a team as a code owner September 19, 2023 14:44
@vsedmik vsedmik self-assigned this Sep 19, 2023
@vsedmik vsedmik requested a review from a team as a code owner September 19, 2023 14:44
@vsedmik
Copy link
Contributor Author

vsedmik commented Sep 19, 2023

trigger: test-robottelo
pytest: tests/foreman/cli/test_satellitesync.py -k 'test_positive_import_content_for_disconnected_sat_with_existing_content or test_postive_export_import_cv_with_long_name or test_positive_export_rerun_failed_import or test_postive_export_import_repo_with_GPG'

@vsedmik
Copy link
Contributor Author

vsedmik commented Sep 20, 2023

rebased

@vsedmik vsedmik force-pushed the iss-s122 branch 2 times, most recently from afaa9fb to 45aabc0 Compare September 25, 2023 19:35
@vsedmik
Copy link
Contributor Author

vsedmik commented Sep 25, 2023

rebased on Jake's ruff and my other PR

@vsedmik
Copy link
Contributor Author

vsedmik commented Sep 25, 2023

trigger: test-robottelo
pytest: tests/foreman/cli/test_satellitesync.py -k 'test_positive_import_content_for_disconnected_sat_with_existing_content or test_postive_export_import_cv_with_long_name or test_positive_export_rerun_failed_import or test_postive_export_import_repo_with_GPG'

jyejare
jyejare reviewed Oct 3, 2023
View reviewed changes
Copy link
Member

@jyejare jyejare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK pending comments/questions!

tests/foreman/cli/test_satellitesync.py Outdated Show resolved Hide resolved
tests/foreman/cli/test_satellitesync.py Show resolved Hide resolved
tests/foreman/cli/test_satellitesync.py Show resolved Hide resolved
@vsedmik
ISS refactor - batch 3
a63f3ef 
Introduced changes:
1. Extended test_positive_import_content_for_disconnected_sat_with_existing_content
   by assertion for correct error message when non-import-only CV is used for import
2. Removed _import_entities
3. Added test for customer scenarios:
   test_postive_export_import_cv_with_long_name
   test_positive_export_rerun_failed_import
   test_postive_export_import_repo_with_GPG
sambible
sambible approved these changes Oct 24, 2023
View reviewed changes
tests/foreman/cli/test_satellitesync.py Show resolved Hide resolved
tests/foreman/cli/test_satellitesync.py Outdated Show resolved Hide resolved
damoore044
damoore044 approved these changes Oct 31, 2023
View reviewed changes
Copy link
Contributor

@damoore044 damoore044 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, last prt run was 1 month ago, quick rerun before merge

@damoore044
Copy link
Contributor

trigger: test-robottelo
pytest: tests/foreman/cli/test_satellitesync.py -k 'test_positive_import_content_for_disconnected_sat_with_existing_content or test_postive_export_import_cv_with_long_name or test_positive_export_rerun_failed_import or test_postive_export_import_repo_with_GPG'

@damoore044 damoore044 merged commit aa0b931 into SatelliteQE:master Oct 31, 2023
5 checks passed
This was referenced Oct 31, 2023
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vijaysawant vijaysawant vijaysawant left review comments

@damoore044 damoore044 damoore044 approved these changes

@sambible sambible sambible approved these changes

@jyejare jyejare jyejare approved these changes

Assignees

@vsedmik vsedmik

Labels
6.12.z Introduced in or relating directly to Satellite 6.12 6.13.z Introduced in or relating directly to Satellite 6.13 6.14.z Introduced in or relating directly to Satellite 6.14 AutoMerge_Cherry_Picked The cherrypicked PRs of master PR would be automerged if all checks passing CherryPick PR needs CherryPick to previous branches CLI Issues and PRs involving the CLI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@vsedmik @damoore044 @jyejare @sambible @vijaysawant