Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[6.12.z] ISS refactor - batch 3 #13020

Conversation

Satellite-QE
Copy link
Collaborator

Cherrypick of PR: #12651

Based on #12347.

Introduced changes:

  1. Extended test_positive_import_content_for_disconnected_sat_with_existing_content by assertion for correct error message when non-import-only CV is used for import
  2. Removed _import_entities
  3. Added test for customer scenarios:
    test_postive_export_import_cv_with_long_name
    test_positive_export_rerun_failed_import
    test_postive_export_import_repo_with_GPG

@Satellite-QE Satellite-QE added 6.12.z Introduced in or relating directly to Satellite 6.12 Auto_Cherry_Picked Automatically cherrypicked PR using GHA No-CherryPick PR doesnt need CherryPick to previous branches labels Oct 31, 2023
@Satellite-QE
Copy link
Collaborator Author

trigger: test-robottelo
pytest: tests/foreman/cli/test_satellitesync.py -k 'test_positive_import_content_for_disconnected_sat_with_existing_content or test_postive_export_import_cv_with_long_name or test_positive_export_rerun_failed_import or test_postive_export_import_repo_with_GPG'

@Satellite-QE Satellite-QE added the AutoMerge_Cherry_Picked The cherrypicked PRs of master PR would be automerged if all checks passing label Oct 31, 2023
@vsedmik
Copy link
Contributor

vsedmik commented Nov 1, 2023

test_postive_export_import_repo_with_GPG needs to be removed from the PR since the fix was not backported to 6.12.z (and thus failing in PRT)

@vsedmik
Copy link
Contributor

vsedmik commented Nov 2, 2023

trigger: test-robottelo
pytest: tests/foreman/cli/test_satellitesync.py -k 'test_positive_import_content_for_disconnected_sat_with_existing_content or test_postive_export_import_cv_with_long_name or test_positive_export_rerun_failed_import'

vsedmik and others added 3 commits November 2, 2023 11:02
Introduced changes:
1. Extended test_positive_import_content_for_disconnected_sat_with_existing_content
   by assertion for correct error message when non-import-only CV is used for import
2. Removed _import_entities
3. Added test for customer scenarios:
   test_postive_export_import_cv_with_long_name
   test_positive_export_rerun_failed_import
   test_postive_export_import_repo_with_GPG

(cherry picked from commit aa0b931)
@vsedmik vsedmik force-pushed the cherry-pick-6.12.z-aa0b9319f53a67f7b1b4797021aa676556b0bda4 branch from 8e01e64 to 0140a4b Compare November 2, 2023 10:02
@vsedmik
Copy link
Contributor

vsedmik commented Nov 2, 2023

PRT #4562 has just finished with great SUCCESS and ruff is happy too.

@vijaysawant vijaysawant merged commit 291cb8e into 6.12.z Nov 2, 2023
6 of 7 checks passed
@vijaysawant vijaysawant deleted the cherry-pick-6.12.z-aa0b9319f53a67f7b1b4797021aa676556b0bda4 branch November 2, 2023 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.12.z Introduced in or relating directly to Satellite 6.12 Auto_Cherry_Picked Automatically cherrypicked PR using GHA AutoMerge_Cherry_Picked The cherrypicked PRs of master PR would be automerged if all checks passing No-CherryPick PR doesnt need CherryPick to previous branches
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants