Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[6.13.z] ISS refactor - batch 2 #12664

Conversation

Satellite-QE
Copy link
Collaborator

Cherrypick of PR: #12347

Second batch of changes coming from the ISS evaluation

Introduced changes:

  1. Added fixtures for importing orgs. These need to be new orgs so they don't reference the original org fixtures, which are used for export.
  2. _enable_rhel_repo helper function was replaced by parametrized fixture and used through the module.
  3. Using the fixture above three test cases were merged with test_positive_export_import_redhat_cv:
  • test_positive_export_complete_version_rh_repo - was practically same as the first (export) part of the above case.
  • test_positive_export_import_redhat_cv_with_huge_contents - same as the above case but bigger (rhscl) repo.
  • test_positive_export_import_kickstart_tree - was a stub but now it's automated by the case above
    NOTE: The original plan was to test all KS and RHEL repos, however, due to the immediate download policy it would require more than the default 100G. So we need to decide if we want to test the real customer scenarios and go big, or use a small subset to stay bellow 100G.
  1. Added RH repo to test_positive_export_import_default_org_view to address the PX comment.
  2. Moved to SCA org as new default.
  3. Some other minor changes like drift towards target_sat.cli* and docstrings on touched tests.

Second batch of changes coming from the ISS evaluation:
- enable_rhel_repo helper replaced by parametrized fixture
- added other fixtures for importing orgs
- addressed updates as per PX comment
- merged three cases to export/import CV using parametrization
- moved to SCA org as default

(cherry picked from commit a1c51f1)
@Satellite-QE Satellite-QE added 6.13.z Introduced in or relating directly to Satellite 6.13 Auto_Cherry_Picked Automatically cherrypicked PR using GHA No-CherryPick PR doesnt need CherryPick to previous branches labels Sep 20, 2023
@Satellite-QE
Copy link
Collaborator Author

trigger: test-robottelo
pytest: tests/foreman/cli/test_satellitesync.py -k 'test_positive_export_import_default_org_view or test_positive_export_import_redhat_cv or test_positive_export_complete_library_rh_repo or test_negative_import_redhat_cv_without_manifest or test_positive_export_import_cv_end_to_end or test_positive_export_import_promoted_cv or test_negative_import_same_cv_twice or test_postive_export_import_cv_with_file_content or test_postive_export_import_ansible_collection_repo or test_positive_import_content_for_disconnected_sat_with_existing_content'

@Satellite-QE Satellite-QE added the AutoMerge_Cherry_Picked The cherrypicked PRs of master PR would be automerged if all checks passing label Sep 20, 2023
@Griffin-Sullivan Griffin-Sullivan merged commit 37a08f4 into 6.13.z Sep 22, 2023
@Griffin-Sullivan Griffin-Sullivan deleted the cherry-pick-6.13.z-a1c51f1a42bd802a63d758bb517f6c352f5b54d2 branch September 22, 2023 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.13.z Introduced in or relating directly to Satellite 6.13 Auto_Cherry_Picked Automatically cherrypicked PR using GHA AutoMerge_Cherry_Picked The cherrypicked PRs of master PR would be automerged if all checks passing No-CherryPick PR doesnt need CherryPick to previous branches
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants