Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add customer test case for BZ#2212523 #12687

Merged
merged 1 commit into from
Sep 25, 2023
Merged

Add customer test case for BZ#2212523 #12687

merged 1 commit into from
Sep 25, 2023

Conversation

vsedmik
Copy link
Contributor

@vsedmik vsedmik commented Sep 21, 2023

Basically coverage for this BZ but generalized to check all content referenced in repomd.xml in both exports.

@vsedmik vsedmik added CLI Issues and PRs involving the CLI QETestCoverage Issues and PRs relating to a Satellite bug CherryPick PR needs CherryPick to previous branches 6.12.z Introduced in or relating directly to Satellite 6.12 AutoMerge_Cherry_Picked The cherrypicked PRs of master PR would be automerged if all checks passing 6.13.z Introduced in or relating directly to Satellite 6.13 6.14.z Introduced in or relating directly to Satellite 6.14 labels Sep 21, 2023
@vsedmik vsedmik requested a review from a team as a code owner September 21, 2023 14:31
@vsedmik vsedmik self-assigned this Sep 21, 2023
@vsedmik
Copy link
Contributor Author

vsedmik commented Sep 21, 2023

trigger: test-robottelo
pytest: tests/foreman/cli/test_satellitesync.py -k test_positive_export_incremental_syncable_check_content

sambible
sambible approved these changes Sep 21, 2023
View reviewed changes
Copy link
Contributor

@sambible sambible left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ack pending PRT, nice use of grep for file verification :)

ColeHiggins2
ColeHiggins2 reviewed Sep 21, 2023
View reviewed changes
tests/foreman/cli/test_satellitesync.py
)
# Verify that the content referenced in repomd.xml files is present in both exports
repomd_files = target_sat.execute(
f'find {PULP_EXPORT_DIR}{function_sca_manifest_org.name}/{cv_name}/ -name repomd.xml'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are these repomd.xml files in the same locations for 6.14, 6.13, 6.12?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think they should, just the tail of the path will differ for different repos, but that is solved by find.
I will check.

@vsedmik
Copy link
Contributor Author

vsedmik commented Sep 21, 2023

PRT is failing against stream, locally it passed against 6.14. Need to check what's going on there.

@vsedmik
Copy link
Contributor Author

vsedmik commented Sep 21, 2023

trigger: test-robottelo
pytest: tests/foreman/cli/test_satellitesync.py -k test_positive_export_incremental_syncable_check_content

@vsedmik
Copy link
Contributor Author

vsedmik commented Sep 21, 2023

So the PRT fails now due to a regression in Stream which should be resolved soon by fix backporting in pulpcore.
Against 6.14.0 it passes locally.

So it seems the test actually works well! :)

For reference:
issue pulp/pulpcore#3941
fix pulp/pulpcore#3942

@vsedmik
Copy link
Contributor Author

vsedmik commented Sep 25, 2023

rebased on Jake's ruff

@Griffin-Sullivan Griffin-Sullivan merged commit f2ab861 into SatelliteQE:master Sep 25, 2023
@Satellite-QE Satellite-QE mentioned this pull request Sep 25, 2023
Merged
github-actions bot pushed a commit that referenced this pull request Sep 25, 2023
@vsedmik @web-flow
Add customer test case for BZ#2212523 (#12687)
80d13b3 
(cherry picked from commit f2ab861)
@Satellite-QE Satellite-QE mentioned this pull request Sep 25, 2023
Merged
github-actions bot pushed a commit that referenced this pull request Sep 25, 2023
@vsedmik @web-flow
Add customer test case for BZ#2212523 (#12687)
105637c 
(cherry picked from commit f2ab861)
@Satellite-QE Satellite-QE mentioned this pull request Sep 25, 2023
Merged
github-actions bot pushed a commit that referenced this pull request Sep 25, 2023
@vsedmik @web-flow
Add customer test case for BZ#2212523 (#12687)
9864def 
(cherry picked from commit f2ab861)
Griffin-Sullivan pushed a commit that referenced this pull request Sep 26, 2023
@Satellite-QE @vsedmik
[6.14.z] Add customer test case for BZ#2212523 (#12725)
3f9e894 
Add customer test case for BZ#2212523 (#12687)

(cherry picked from commit f2ab861)

Co-authored-by: vsedmik <[email protected]>
damoore044 pushed a commit to damoore044/robottelo that referenced this pull request Oct 4, 2023
@vsedmik @damoore044
Add customer test case for BZ#2212523 (SatelliteQE#12687)
73eaebe
ColeHiggins2 pushed a commit to ColeHiggins2/robottelo that referenced this pull request Oct 9, 2023
@vsedmik @ColeHiggins2
Add customer test case for BZ#2212523 (SatelliteQE#12687)
6a666f8
damoore044 pushed a commit to damoore044/robottelo that referenced this pull request Oct 10, 2023
@vsedmik @damoore044
Add customer test case for BZ#2212523 (SatelliteQE#12687)
b72b37c
shweta83 pushed a commit to shweta83/robottelo that referenced this pull request Apr 10, 2024
@vsedmik @shweta83
Add customer test case for BZ#2212523 (SatelliteQE#12687)
676afd3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ColeHiggins2 ColeHiggins2 ColeHiggins2 left review comments

@Griffin-Sullivan Griffin-Sullivan Griffin-Sullivan approved these changes

@sambible sambible sambible approved these changes

Assignees

@vsedmik vsedmik

Labels
6.12.z Introduced in or relating directly to Satellite 6.12 6.13.z Introduced in or relating directly to Satellite 6.13 6.14.z Introduced in or relating directly to Satellite 6.14 AutoMerge_Cherry_Picked The cherrypicked PRs of master PR would be automerged if all checks passing CherryPick PR needs CherryPick to previous branches CLI Issues and PRs involving the CLI QETestCoverage Issues and PRs relating to a Satellite bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@vsedmik @sambible @ColeHiggins2 @Griffin-Sullivan