Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add test coverage for provisioning with fips_enabled #12695

Merged
merged 1 commit into from
Dec 14, 2023
Merged

Add test coverage for provisioning with fips_enabled #12695

merged 1 commit into from
Dec 14, 2023

Conversation

Gauravtalreja1
Copy link
Collaborator

@Gauravtalreja1 Gauravtalreja1 commented Sep 22, 2023 •
edited
Loading

SSIA

@Gauravtalreja1 Gauravtalreja1 added QETestCoverage Issues and PRs relating to a Satellite bug CherryPick PR needs CherryPick to previous branches 6.12.z Introduced in or relating directly to Satellite 6.12 AutoMerge_Cherry_Picked The cherrypicked PRs of master PR would be automerged if all checks passing 6.13.z Introduced in or relating directly to Satellite 6.13 6.14.z Introduced in or relating directly to Satellite 6.14 labels Sep 22, 2023
@Gauravtalreja1 Gauravtalreja1 requested a review from a team as a code owner September 22, 2023 06:18
@Gauravtalreja1 Gauravtalreja1 self-assigned this Sep 22, 2023
@Gauravtalreja1
Copy link
Collaborator Author

trigger: test-robottelo
pytest: tests/foreman/api/test_provisioningtemplate.py::TestProvisioningTemplate::test_positive_template_check_fips_enabled

@shubhamsg199
Copy link
Contributor

trigger: test-robottelo
pytest: tests/foreman/api/test_provisioning.py::test_rhel_pxe_provisioning_fips_enabled
provisioning: true

@Gauravtalreja1 Gauravtalreja1 force-pushed the closeloop-fips-provisioning branch from 11dd8c6 to b7ce955 Compare September 27, 2023 22:53
@Gauravtalreja1 Gauravtalreja1 requested a review from a team as a code owner September 27, 2023 22:53
@Gauravtalreja1 Gauravtalreja1 mentioned this pull request Oct 3, 2023
Merged
@shubhamsg199
Copy link
Contributor

trigger: test-robottelo
pytest: tests/foreman/api/test_provisioning.py::test_rhel_pxe_provisioning_fips_enabled
provisioning: true

@Gauravtalreja1 Gauravtalreja1 force-pushed the closeloop-fips-provisioning branch from b7ce955 to 3242255 Compare October 5, 2023 10:38
@shubhamsg199
Copy link
Contributor

trigger: test-robottelo
pytest: tests/foreman/api/test_provisioning.py::test_rhel_pxe_provisioning_fips_enabled
provisioning: true

@Gauravtalreja1 Gauravtalreja1 removed the 6.13.z Introduced in or relating directly to Satellite 6.13 label Oct 5, 2023
@Gauravtalreja1 Gauravtalreja1 force-pushed the closeloop-fips-provisioning branch from 3242255 to dd236c1 Compare October 5, 2023 22:47
@Gauravtalreja1 Gauravtalreja1 force-pushed the closeloop-fips-provisioning branch 2 times, most recently from 13ee716 to f329b91 Compare October 26, 2023 13:26
@Gauravtalreja1 Gauravtalreja1 force-pushed the closeloop-fips-provisioning branch from f329b91 to f1fb65b Compare November 2, 2023 22:42
@Gauravtalreja1 Gauravtalreja1 added the 6.15.z Introduced in or relating directly to Satellite 6.15 label Nov 28, 2023
lhellebr
lhellebr requested changes Nov 28, 2023
View reviewed changes
Copy link
Contributor

@lhellebr lhellebr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this blocked on something? The PR has been here for quite some time and it seems almost finished. I'd ACK if this passed the style check and PRT was green.

@Gauravtalreja1 Gauravtalreja1 force-pushed the closeloop-fips-provisioning branch from f1fb65b to 314c4c9 Compare December 4, 2023 09:30
@Gauravtalreja1 Gauravtalreja1 force-pushed the closeloop-fips-provisioning branch 2 times, most recently from bbc208c to 9f0a5a1 Compare December 12, 2023 20:37
@Gauravtalreja1
Copy link
Collaborator Author

trigger: test-robottelo
pytest: tests/foreman/api/test_provisioning.py::test_rhel_pxe_provisioning_fips_enabled
provisioning: true
pod_resources_size: extra_large

@Gauravtalreja1 Gauravtalreja1 force-pushed the closeloop-fips-provisioning branch from 9f0a5a1 to a6609ff Compare December 13, 2023 07:05
@Gauravtalreja1
Copy link
Collaborator Author

PRT passed in run 4939, just fixed the failing make docs check, so this PR is RFR now

shubhamsg199
shubhamsg199 approved these changes Dec 13, 2023
View reviewed changes
Copy link
Contributor

@shubhamsg199 shubhamsg199 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

@adarshdubey-star
Copy link
Contributor

Can you please add some description.

@omkarkhatavkar omkarkhatavkar merged commit c740d61 into SatelliteQE:master Dec 14, 2023
5 checks passed
github-actions bot pushed a commit that referenced this pull request Dec 14, 2023
@Gauravtalreja1 @web-flow
Add test coverage for provisioning with fips_enabled (#12695)
595101f 
Signed-off-by: Gaurav Talreja <[email protected]>
(cherry picked from commit c740d61)
This was referenced Dec 14, 2023
Closed
Merged
Closed
Gauravtalreja1 added a commit to Gauravtalreja1/robottelo that referenced this pull request Dec 14, 2023
@Gauravtalreja1
Add test coverage for provisioning with fips_enabled (SatelliteQE#12695)
30c9b9a 
Signed-off-by: Gaurav Talreja <[email protected]>
(cherry picked from commit c740d61)
Gauravtalreja1 added a commit to Gauravtalreja1/robottelo that referenced this pull request Dec 14, 2023
@Gauravtalreja1
Add test coverage for provisioning with fips_enabled (SatelliteQE#12695)
6e6817c 
Signed-off-by: Gaurav Talreja <[email protected]>
(cherry picked from commit c740d61)
@Gauravtalreja1 Gauravtalreja1 mentioned this pull request Dec 14, 2023
Merged
@Gauravtalreja1 Gauravtalreja1 deleted the closeloop-fips-provisioning branch December 14, 2023 07:59
shubhamsg199 pushed a commit that referenced this pull request Dec 15, 2023
@Gauravtalreja1
[6.13.z] Add test coverage for provisioning with fips_enabled (#12787)
4a7ca74 
Add test coverage for provisioning with fips_enabled (#12695)

Signed-off-by: Gaurav Talreja <[email protected]>
(cherry picked from commit c740d61)
shubhamsg199 pushed a commit that referenced this pull request Dec 15, 2023
@Gauravtalreja1
[6.14.z] Add test coverage for provisioning with fips_enabled (#13458)
fbef12f 
Add test coverage for provisioning with fips_enabled (#12695)

Signed-off-by: Gaurav Talreja <[email protected]>
(cherry picked from commit c740d61)
shubhamsg199 pushed a commit that referenced this pull request Dec 15, 2023
@Satellite-QE @Gauravtalreja1
[6.15.z] Add test coverage for provisioning with fips_enabled (#13456)
fbc7caf 
Add test coverage for provisioning with fips_enabled (#12695)

Signed-off-by: Gaurav Talreja <[email protected]>
(cherry picked from commit c740d61)

Co-authored-by: Gaurav Talreja <[email protected]>
shweta83 pushed a commit to shweta83/robottelo that referenced this pull request Apr 10, 2024
@Gauravtalreja1 @shweta83
Add test coverage for provisioning with fips_enabled (SatelliteQE#12695)
12fc45e 
Signed-off-by: Gaurav Talreja <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shweta83 shweta83 shweta83 left review comments

@vijaysawant vijaysawant vijaysawant left review comments

@ogajduse ogajduse ogajduse left review comments

@lhellebr lhellebr lhellebr requested changes

@shubhamsg199 shubhamsg199 shubhamsg199 approved these changes

@adarshdubey-star adarshdubey-star adarshdubey-star approved these changes

@omkarkhatavkar omkarkhatavkar omkarkhatavkar approved these changes

Assignees

@Gauravtalreja1 Gauravtalreja1

Labels
6.12.z Introduced in or relating directly to Satellite 6.12 6.14.z Introduced in or relating directly to Satellite 6.14 6.15.z Introduced in or relating directly to Satellite 6.15 AutoMerge_Cherry_Picked The cherrypicked PRs of master PR would be automerged if all checks passing CherryPick PR needs CherryPick to previous branches QETestCoverage Issues and PRs relating to a Satellite bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@Gauravtalreja1 @shubhamsg199 @adarshdubey-star @omkarkhatavkar @lhellebr @ogajduse @vijaysawant @shweta83