Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate katello-agent tests to REX #12724

Merged
merged 2 commits into from
Oct 2, 2023
Merged

Migrate katello-agent tests to REX #12724

merged 2 commits into from
Oct 2, 2023

Conversation

vsedmik
Copy link
Contributor

@vsedmik vsedmik commented Sep 25, 2023

Katello agent was deprecated and is being removed from 6.15, the functionality will be replaced by REX.
This PR moves testing of the functionality towards REX.

@vsedmik vsedmik added CLI Issues and PRs involving the CLI No-CherryPick PR doesnt need CherryPick to previous branches Stream Introduced in or relating directly to Satellite Stream/Master labels Sep 25, 2023
@vsedmik vsedmik requested a review from pondrejk September 25, 2023 18:46
@vsedmik vsedmik requested review from a team as code owners September 25, 2023 18:46
@vsedmik vsedmik self-assigned this Sep 25, 2023
@vsedmik
Copy link
Contributor Author

vsedmik commented Sep 25, 2023

trigger: test-robottelo
pytest: tests/foreman/cli/test_remoteexecution.py -k 'test_positive_install_remove_multiple_packages_with_a_job_by_ip or test_positive_install_remove_packagegroup_with_a_job_by_ip or test_positive_install_errata_with_a_job_by_ip or test_positive_match_feature_names'

@vsedmik vsedmik force-pushed the rex-ka-migration branch 3 times, most recently from 9a73c44 to 3888661 Compare September 27, 2023 09:19
lhellebr
lhellebr approved these changes Sep 27, 2023
View reviewed changes
Copy link
Contributor

@lhellebr lhellebr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nonblocking comments, LGTM

tests/foreman/cli/test_remoteexecution.py
@@ -269,15 +286,15 @@ def test_positive_run_default_job_template_multiple_hosts_by_ip(
@pytest.mark.skipif(
(not settings.robottelo.repos_hosting_url), reason='Missing repos_hosting_url'
)
def test_positive_install_multiple_packages_with_a_job_by_ip(
def test_positive_install_remove_multiple_packages_with_a_job(
Copy link
Contributor

@lhellebr lhellebr Sep 27, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since you removed the _by_ip nonsense here, how about doing it for a whole file so the change happens in one commit? I see e.g. test_positive_run_default_job_template_multiple_hosts_by_ip.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Discussed with @pondrejk and decided to remove it globally.

tests/foreman/cli/test_remoteexecution.py
}
)
assert_job_invocation_result(invocation_command['id'], client.hostname)
result = client.run('dnf grouplist --installed')
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know this is set to only run on RHEL8 for now... but how about using variable for a packaging manager name?

@pondrejk
Copy link
Contributor

pondrejk commented Sep 27, 2023 •
edited
Loading

ci issue most likely unrelated

  • ^ scratch that, there is a pre-commit problem

@pondrejk pondrejk enabled auto-merge (rebase) September 27, 2023 10:58
@pondrejk pondrejk disabled auto-merge September 27, 2023 10:59
@vsedmik
Copy link
Contributor Author

vsedmik commented Sep 27, 2023

pre-commit was fixed, CI/CQ is failing on something unrelated it seems

 /opt/hostedtoolcache/Python/3.10.13/x64/lib/python3.10/site-packages/autoapi/mappers/python/mapper.py:294: RemovedInSphinx80Warning: The alias 'sphinx.util.status_iterator' is deprecated, use 'sphinx.util.display.status_iterator' instead. Check CHANGES for Sphinx API modifications.
  for dir_root, path in sphinx.util.status_iterator(

Extension error (autoapi.extension):
Handler <function run_autoapi at 0x7f70dcecca60> for event 'builder-inited' threw an exception (exception: 'Module' object has no attribute 'doc')
[AutoAPI] Reading files... [  1%] /home/runner/work/robottelo/robottelo/robottelo/logging.py
make[1]: *** [Makefile:45: html] Error 2

@vsedmik
Migrate katello-agent tests to REX
7f4163f 
Katello agent was deprecated and is being removed from 6.15, the
functionality will be replaced by REX.
This PR moves testing of the functionality towards REX.
@vsedmik
Remove _by_ip postfix from REX tests
21d0db7
@Griffin-Sullivan Griffin-Sullivan merged commit 9f3d029 into SatelliteQE:master Oct 2, 2023
5 checks passed
damoore044 pushed a commit to damoore044/robottelo that referenced this pull request Oct 4, 2023
@vsedmik @damoore044
Migrate katello-agent tests to REX (SatelliteQE#12724)
7827e66 
* Migrate katello-agent tests to REX

Katello agent was deprecated and is being removed from 6.15, the
functionality will be replaced by REX.
This PR moves testing of the functionality towards REX.

* Remove _by_ip postfix from REX tests
ColeHiggins2 pushed a commit to ColeHiggins2/robottelo that referenced this pull request Oct 9, 2023
@vsedmik @ColeHiggins2
Migrate katello-agent tests to REX (SatelliteQE#12724)
23beb20 
* Migrate katello-agent tests to REX

Katello agent was deprecated and is being removed from 6.15, the
functionality will be replaced by REX.
This PR moves testing of the functionality towards REX.

* Remove _by_ip postfix from REX tests
damoore044 pushed a commit to damoore044/robottelo that referenced this pull request Oct 10, 2023
@vsedmik @damoore044
Migrate katello-agent tests to REX (SatelliteQE#12724)
688c8bc 
* Migrate katello-agent tests to REX

Katello agent was deprecated and is being removed from 6.15, the
functionality will be replaced by REX.
This PR moves testing of the functionality towards REX.

* Remove _by_ip postfix from REX tests
shweta83 pushed a commit to shweta83/robottelo that referenced this pull request Apr 10, 2024
@vsedmik @shweta83
Migrate katello-agent tests to REX (SatelliteQE#12724)
0cc7bdc 
* Migrate katello-agent tests to REX

Katello agent was deprecated and is being removed from 6.15, the
functionality will be replaced by REX.
This PR moves testing of the functionality towards REX.

* Remove _by_ip postfix from REX tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adarshdubey-star adarshdubey-star adarshdubey-star approved these changes

@Griffin-Sullivan Griffin-Sullivan Griffin-Sullivan approved these changes

@synkd synkd synkd approved these changes

@sambible sambible sambible approved these changes

@pondrejk pondrejk pondrejk approved these changes

@lhellebr lhellebr lhellebr approved these changes

Assignees

@vsedmik vsedmik

Labels
CLI Issues and PRs involving the CLI No-CherryPick PR doesnt need CherryPick to previous branches Stream Introduced in or relating directly to Satellite Stream/Master
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@vsedmik @pondrejk @lhellebr @sambible @synkd @Griffin-Sullivan @adarshdubey-star