Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add customer coverage to health check #12745

Merged
merged 1 commit into from
Oct 3, 2023
Merged

Add customer coverage to health check #12745

merged 1 commit into from
Oct 3, 2023

Conversation

Griffin-Sullivan
Copy link
Contributor

Adding coverage for BZ1956210. Just need to assert that health check doesn't cause an SSL error.

@Griffin-Sullivan Griffin-Sullivan added CherryPick PR needs CherryPick to previous branches 6.12.z Introduced in or relating directly to Satellite 6.12 AutoMerge_Cherry_Picked The cherrypicked PRs of master PR would be automerged if all checks passing 6.13.z Introduced in or relating directly to Satellite 6.13 6.14.z Introduced in or relating directly to Satellite 6.14 labels Sep 26, 2023
@Griffin-Sullivan Griffin-Sullivan requested a review from a team as a code owner September 26, 2023 16:26
@Griffin-Sullivan
Copy link
Contributor Author

trigger: test-robottelo
pytest: tests/foreman/maintain/test_health.py::test_positive_health_check

@Griffin-Sullivan
Copy link
Contributor Author

The reason for the changes in test_repository are due to ruff being added to pre-commit.

@Griffin-Sullivan
Copy link
Contributor Author

trigger: test-robottelo
pytest: tests/foreman/maintain/test_health.py::test_positive_health_check

ColeHiggins2
ColeHiggins2 approved these changes Sep 29, 2023
View reviewed changes
Copy link
Member

@ColeHiggins2 ColeHiggins2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK pending code quality failure

@Griffin-Sullivan
Copy link
Contributor Author

PRT on this passed already, but it got removed from the checks because I had to rebase in order to fix the Code Quality failure.

@sambible sambible merged commit 418b330 into SatelliteQE:master Oct 3, 2023
5 checks passed
This was referenced Oct 3, 2023
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ColeHiggins2 ColeHiggins2 ColeHiggins2 approved these changes

@sambible sambible sambible approved these changes

Assignees

@Griffin-Sullivan Griffin-Sullivan

Labels
6.12.z Introduced in or relating directly to Satellite 6.12 6.13.z Introduced in or relating directly to Satellite 6.13 6.14.z Introduced in or relating directly to Satellite 6.14 AutoMerge_Cherry_Picked The cherrypicked PRs of master PR would be automerged if all checks passing CherryPick PR needs CherryPick to previous branches
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Griffin-Sullivan @sambible @ColeHiggins2