[6.12.z] Add in the caching mechanism to the Satellite's api property #12772
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should have always existed but was overlooked. It will dramatically decrease the amount of time it takes to access the api property since it doesn't need to be reconstructed each time the property is accessed. Before ------ %timeit mysat.api.Host 3.62 ms ± 52.4 µs per loop (mean ± std. dev. of 7 runs, 100 loops each) After ----- %timeit mysat.api.Host 189 ns ± 0.943 ns per loop (mean ± std. dev. of 7 runs, 10,000,000 loops each) (cherry picked from commit b3d32b6)
Satellite-QE
added
6.12.z
|
trigger: test-robottelo |
JacobCallahan
approved these changes
Sep 28, 2023
JacobCallahan
deleted the
cherry-pick-6.12.z-b3d32b6d7aa568f5532eaf02fba3a5f062c517a5
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherrypick of PR: #12765
This should have always existed but was overlooked. It will dramatically decrease the amount of time it takes to access the api property since it doesn't need to be reconstructed each time the property is accessed.
Before
%timeit mysat.api.Host
3.62 ms ± 52.4 µs per loop (mean ± std. dev. of 7 runs, 100 loops each)
After
%timeit mysat.api.Host
189 ns ± 0.943 ns per loop (mean ± std. dev. of 7 runs, 10,000,000 loops each)