Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Python 3.12 to supported versions #12793

Merged
merged 3 commits into from
Feb 7, 2024

Conversation

JacobCallahan
Copy link
Member

Python 3.12 is out and should be supported by Robottelo. Also switched the weekly workflow to use Python 3.12 instead of 3.11.

@JacobCallahan JacobCallahan added CherryPick PR needs CherryPick to previous branches 6.12.z Introduced in or relating directly to Satellite 6.12 6.13.z Introduced in or relating directly to Satellite 6.13 6.14.z Introduced in or relating directly to Satellite 6.14 labels Oct 3, 2023
@JacobCallahan JacobCallahan requested a review from a team as a code owner October 3, 2023 12:13
@jyejare
Copy link
Member

jyejare commented Oct 3, 2023

@JacobCallahan Dependencies installation is failing for 6.12 in configparser.

@JacobCallahan
Copy link
Member Author

Blocked on ParallelSSH/ssh2-python#193

@JacobCallahan JacobCallahan marked this pull request as draft October 3, 2023 12:54
Copy link

This pull request has not been updated in the past 45 days.

@github-actions github-actions bot added the Stale Stale issue or Pull Request label Nov 18, 2023
@Gauravtalreja1 Gauravtalreja1 removed the Stale Stale issue or Pull Request label Nov 20, 2023
@ogajduse ogajduse linked an issue Nov 22, 2023 that may be closed by this pull request
3 tasks
Copy link

github-actions bot commented Jan 5, 2024

This pull request has not been updated in the past 45 days.

@github-actions github-actions bot added the Stale Stale issue or Pull Request label Jan 5, 2024
@JacobCallahan JacobCallahan removed the Stale Stale issue or Pull Request label Jan 5, 2024
@JacobCallahan
Copy link
Member Author

Removing stale since there are now updates on SatelliteQE/broker#251

@jyejare jyejare added the Framework Changes A modification of the robottelo framework label Jan 9, 2024
@JacobCallahan
Copy link
Member Author

trigger: test-robottelo
broker: 251
pytest: tests/foreman/ -k 'test_host_registration_end_to_end or test_positive_erratum_applicability or test_positive_upload_content'

@JacobCallahan
Copy link
Member Author

trigger: test-robottelo
broker: 251
pytest: tests/foreman/ -k 'test_host_registration_end_to_end or test_positive_erratum_applicability or test_positive_upload_content'

@JacobCallahan
Copy link
Member Author

Out of the 26 tests ran by PRT, 23 passed. The 3 that failed did so due to errors unrelated to Broker itself. Will proceed with a new Broker release and update this PR after.

@JacobCallahan
Copy link
Member Author

It looks like there were a number of long-deprecated changes in unittest that have been removed in python 3.12

@JacobCallahan
Copy link
Member Author

trigger: test-robottelo
broker: 251
pytest: tests/foreman/ -k 'test_host_registration_end_to_end or test_positive_erratum_applicability or test_positive_upload_content'

Python 3.12 is out and should be supported by Robottelo. Also switched
the weekly workflow to use Python 3.12 instead of 3.11.
This commit introduces a few changes relating to unittest changes and
differences post-removal of old behavior.
@JacobCallahan
Copy link
Member Author

trigger: test-robottelo
pytest: tests/foreman/ -k end_to_end

@JacobCallahan JacobCallahan marked this pull request as ready for review February 5, 2024 16:41
@JacobCallahan JacobCallahan requested a review from a team as a code owner February 5, 2024 16:41
@JacobCallahan
Copy link
Member Author

Looking through the results, I don't see any failures attributable to this PR.

Copy link
Member

@jyejare jyejare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Good!

Comment on lines +35 to +36
# [1] - https://github.com/ParallelSSH/ssh2-python/issues/193
# [2] - https://github.com/pypi/warehouse/issues/7136
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think both of these issues have been resolved now, so can we keep this the way it is?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And the pypi issue is closed as a wontfix, so the issue is still affecting us. I have an idea about the latter, but we need this for now.

Copy link
Member

@ogajduse ogajduse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All changes LGTM. 🚀

@Gauravtalreja1 Gauravtalreja1 added the AutoMerge_Cherry_Picked The cherrypicked PRs of master PR would be automerged if all checks passing label Feb 7, 2024
Copy link
Collaborator

@Gauravtalreja1 Gauravtalreja1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JacobCallahan LGTM, Thank you for adding this! ❤️

@Gauravtalreja1 Gauravtalreja1 merged commit e7cf6dd into SatelliteQE:master Feb 7, 2024
8 of 9 checks passed
@JacobCallahan JacobCallahan deleted the py312 branch February 7, 2024 18:11
jyejare pushed a commit to jyejare/robottelo that referenced this pull request Apr 2, 2024
* Add Python 3.12 to supported versions

Python 3.12 is out and should be supported by Robottelo. Also switched
the weekly workflow to use Python 3.12 instead of 3.11.

* update unittest deprecations

* Adjust unit tests for python 3.12

This commit introduces a few changes relating to unittest changes and
differences post-removal of old behavior.
jyejare pushed a commit to jyejare/robottelo that referenced this pull request Apr 2, 2024
* Add Python 3.12 to supported versions

Python 3.12 is out and should be supported by Robottelo. Also switched
the weekly workflow to use Python 3.12 instead of 3.11.

* update unittest deprecations

* Adjust unit tests for python 3.12

This commit introduces a few changes relating to unittest changes and
differences post-removal of old behavior.
jyejare pushed a commit to jyejare/robottelo that referenced this pull request Apr 2, 2024
* Add Python 3.12 to supported versions

Python 3.12 is out and should be supported by Robottelo. Also switched
the weekly workflow to use Python 3.12 instead of 3.11.

* update unittest deprecations

* Adjust unit tests for python 3.12

This commit introduces a few changes relating to unittest changes and
differences post-removal of old behavior.
jyejare pushed a commit to jyejare/robottelo that referenced this pull request Apr 2, 2024
* Add Python 3.12 to supported versions

Python 3.12 is out and should be supported by Robottelo. Also switched
the weekly workflow to use Python 3.12 instead of 3.11.

* update unittest deprecations

* Adjust unit tests for python 3.12

This commit introduces a few changes relating to unittest changes and
differences post-removal of old behavior.
jyejare added a commit that referenced this pull request Apr 2, 2024
Add Python 3.12 to supported versions (#12793)

* Add Python 3.12 to supported versions

Python 3.12 is out and should be supported by Robottelo. Also switched
the weekly workflow to use Python 3.12 instead of 3.11.

* update unittest deprecations

* Adjust unit tests for python 3.12

This commit introduces a few changes relating to unittest changes and
differences post-removal of old behavior.

Co-authored-by: Jake Callahan <[email protected]>
jyejare added a commit to jyejare/robottelo that referenced this pull request Apr 3, 2024
Add Python 3.12 to supported versions (SatelliteQE#12793)

* Add Python 3.12 to supported versions

Python 3.12 is out and should be supported by Robottelo. Also switched
the weekly workflow to use Python 3.12 instead of 3.11.

* update unittest deprecations

* Adjust unit tests for python 3.12

This commit introduces a few changes relating to unittest changes and
differences post-removal of old behavior.

Co-authored-by: Jake Callahan <[email protected]>
jyejare added a commit to jyejare/robottelo that referenced this pull request Apr 3, 2024
Add Python 3.12 to supported versions (SatelliteQE#12793)

* Add Python 3.12 to supported versions

Python 3.12 is out and should be supported by Robottelo. Also switched
the weekly workflow to use Python 3.12 instead of 3.11.

* update unittest deprecations

* Adjust unit tests for python 3.12

This commit introduces a few changes relating to unittest changes and
differences post-removal of old behavior.

Co-authored-by: Jake Callahan <[email protected]>
jyejare added a commit to jyejare/robottelo that referenced this pull request Apr 3, 2024
Add Python 3.12 to supported versions (SatelliteQE#12793)

* Add Python 3.12 to supported versions

Python 3.12 is out and should be supported by Robottelo. Also switched
the weekly workflow to use Python 3.12 instead of 3.11.

* update unittest deprecations

* Adjust unit tests for python 3.12

This commit introduces a few changes relating to unittest changes and
differences post-removal of old behavior.

Co-authored-by: Jake Callahan <[email protected]>
jyejare added a commit that referenced this pull request Apr 3, 2024
zStream Checks for Python 3.12 (#14558)

Add Python 3.12 to supported versions (#12793)

* Add Python 3.12 to supported versions

Python 3.12 is out and should be supported by Robottelo. Also switched
the weekly workflow to use Python 3.12 instead of 3.11.

* update unittest deprecations

* Adjust unit tests for python 3.12

This commit introduces a few changes relating to unittest changes and
differences post-removal of old behavior.

Co-authored-by: Jake Callahan <[email protected]>
jyejare added a commit that referenced this pull request Apr 3, 2024
zStream Checks for Python 3.12 (#14558)

Add Python 3.12 to supported versions (#12793)

* Add Python 3.12 to supported versions

Python 3.12 is out and should be supported by Robottelo. Also switched
the weekly workflow to use Python 3.12 instead of 3.11.

* update unittest deprecations

* Adjust unit tests for python 3.12

This commit introduces a few changes relating to unittest changes and
differences post-removal of old behavior.

Co-authored-by: Jake Callahan <[email protected]>
jyejare added a commit that referenced this pull request Apr 3, 2024
zStream Checks for Python 3.12 (#14558)

Add Python 3.12 to supported versions (#12793)

* Add Python 3.12 to supported versions

Python 3.12 is out and should be supported by Robottelo. Also switched
the weekly workflow to use Python 3.12 instead of 3.11.

* update unittest deprecations

* Adjust unit tests for python 3.12

This commit introduces a few changes relating to unittest changes and
differences post-removal of old behavior.

Co-authored-by: Jake Callahan <[email protected]>
shweta83 pushed a commit to shweta83/robottelo that referenced this pull request Apr 10, 2024
* Add Python 3.12 to supported versions

Python 3.12 is out and should be supported by Robottelo. Also switched
the weekly workflow to use Python 3.12 instead of 3.11.

* update unittest deprecations

* Adjust unit tests for python 3.12

This commit introduces a few changes relating to unittest changes and
differences post-removal of old behavior.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.12.z Introduced in or relating directly to Satellite 6.12 6.13.z Introduced in or relating directly to Satellite 6.13 6.14.z Introduced in or relating directly to Satellite 6.14 AutoMerge_Cherry_Picked The cherrypicked PRs of master PR would be automerged if all checks passing CherryPick PR needs CherryPick to previous branches Framework Changes A modification of the robottelo framework
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Robottelo setup on Python 3.12
4 participants