-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Python 3.12 to supported versions #12793
Conversation
@JacobCallahan Dependencies installation is failing for 6.12 in configparser. |
Blocked on ParallelSSH/ssh2-python#193 |
This pull request has not been updated in the past 45 days. |
This pull request has not been updated in the past 45 days. |
Removing stale since there are now updates on SatelliteQE/broker#251 |
trigger: test-robottelo |
trigger: test-robottelo |
Out of the 26 tests ran by PRT, 23 passed. The 3 that failed did so due to errors unrelated to Broker itself. Will proceed with a new Broker release and update this PR after. |
It looks like there were a number of long-deprecated changes in unittest that have been removed in python 3.12 |
trigger: test-robottelo |
Python 3.12 is out and should be supported by Robottelo. Also switched the weekly workflow to use Python 3.12 instead of 3.11.
This commit introduces a few changes relating to unittest changes and differences post-removal of old behavior.
trigger: test-robottelo |
Looking through the results, I don't see any failures attributable to this PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks Good!
# [1] - https://github.com/ParallelSSH/ssh2-python/issues/193 | ||
# [2] - https://github.com/pypi/warehouse/issues/7136 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think both of these issues have been resolved now, so can we keep this the way it is?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Gauravtalreja1 ParallelSSH/ssh2-python#193 is still open.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And the pypi issue is closed as a wontfix, so the issue is still affecting us. I have an idea about the latter, but we need this for now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All changes LGTM. 🚀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@JacobCallahan LGTM, Thank you for adding this! ❤️
* Add Python 3.12 to supported versions Python 3.12 is out and should be supported by Robottelo. Also switched the weekly workflow to use Python 3.12 instead of 3.11. * update unittest deprecations * Adjust unit tests for python 3.12 This commit introduces a few changes relating to unittest changes and differences post-removal of old behavior.
* Add Python 3.12 to supported versions Python 3.12 is out and should be supported by Robottelo. Also switched the weekly workflow to use Python 3.12 instead of 3.11. * update unittest deprecations * Adjust unit tests for python 3.12 This commit introduces a few changes relating to unittest changes and differences post-removal of old behavior.
* Add Python 3.12 to supported versions Python 3.12 is out and should be supported by Robottelo. Also switched the weekly workflow to use Python 3.12 instead of 3.11. * update unittest deprecations * Adjust unit tests for python 3.12 This commit introduces a few changes relating to unittest changes and differences post-removal of old behavior.
* Add Python 3.12 to supported versions Python 3.12 is out and should be supported by Robottelo. Also switched the weekly workflow to use Python 3.12 instead of 3.11. * update unittest deprecations * Adjust unit tests for python 3.12 This commit introduces a few changes relating to unittest changes and differences post-removal of old behavior.
Add Python 3.12 to supported versions (#12793) * Add Python 3.12 to supported versions Python 3.12 is out and should be supported by Robottelo. Also switched the weekly workflow to use Python 3.12 instead of 3.11. * update unittest deprecations * Adjust unit tests for python 3.12 This commit introduces a few changes relating to unittest changes and differences post-removal of old behavior. Co-authored-by: Jake Callahan <[email protected]>
Add Python 3.12 to supported versions (SatelliteQE#12793) * Add Python 3.12 to supported versions Python 3.12 is out and should be supported by Robottelo. Also switched the weekly workflow to use Python 3.12 instead of 3.11. * update unittest deprecations * Adjust unit tests for python 3.12 This commit introduces a few changes relating to unittest changes and differences post-removal of old behavior. Co-authored-by: Jake Callahan <[email protected]>
Add Python 3.12 to supported versions (SatelliteQE#12793) * Add Python 3.12 to supported versions Python 3.12 is out and should be supported by Robottelo. Also switched the weekly workflow to use Python 3.12 instead of 3.11. * update unittest deprecations * Adjust unit tests for python 3.12 This commit introduces a few changes relating to unittest changes and differences post-removal of old behavior. Co-authored-by: Jake Callahan <[email protected]>
Add Python 3.12 to supported versions (SatelliteQE#12793) * Add Python 3.12 to supported versions Python 3.12 is out and should be supported by Robottelo. Also switched the weekly workflow to use Python 3.12 instead of 3.11. * update unittest deprecations * Adjust unit tests for python 3.12 This commit introduces a few changes relating to unittest changes and differences post-removal of old behavior. Co-authored-by: Jake Callahan <[email protected]>
zStream Checks for Python 3.12 (#14558) Add Python 3.12 to supported versions (#12793) * Add Python 3.12 to supported versions Python 3.12 is out and should be supported by Robottelo. Also switched the weekly workflow to use Python 3.12 instead of 3.11. * update unittest deprecations * Adjust unit tests for python 3.12 This commit introduces a few changes relating to unittest changes and differences post-removal of old behavior. Co-authored-by: Jake Callahan <[email protected]>
zStream Checks for Python 3.12 (#14558) Add Python 3.12 to supported versions (#12793) * Add Python 3.12 to supported versions Python 3.12 is out and should be supported by Robottelo. Also switched the weekly workflow to use Python 3.12 instead of 3.11. * update unittest deprecations * Adjust unit tests for python 3.12 This commit introduces a few changes relating to unittest changes and differences post-removal of old behavior. Co-authored-by: Jake Callahan <[email protected]>
zStream Checks for Python 3.12 (#14558) Add Python 3.12 to supported versions (#12793) * Add Python 3.12 to supported versions Python 3.12 is out and should be supported by Robottelo. Also switched the weekly workflow to use Python 3.12 instead of 3.11. * update unittest deprecations * Adjust unit tests for python 3.12 This commit introduces a few changes relating to unittest changes and differences post-removal of old behavior. Co-authored-by: Jake Callahan <[email protected]>
* Add Python 3.12 to supported versions Python 3.12 is out and should be supported by Robottelo. Also switched the weekly workflow to use Python 3.12 instead of 3.11. * update unittest deprecations * Adjust unit tests for python 3.12 This commit introduces a few changes relating to unittest changes and differences post-removal of old behavior.
Python 3.12 is out and should be supported by Robottelo. Also switched the weekly workflow to use Python 3.12 instead of 3.11.