Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[6.13.z] Add coverage for 2055790 to service enable disable #12804

Conversation

Satellite-QE
Copy link
Collaborator

Cherrypick of PR: #12756

The first commit here is a cherry-pick of an old PR that I accidentally removed in one of my Foreman Maintain audits. I must not have had the latest changes on that branch. I'm adding that back in and also adding coverage for 2055790.

* Adding wait for to service enable test

* Add coverage for 2055790 to enable disable

(cherry picked from commit 89b779b)
@Satellite-QE Satellite-QE added 6.13.z Introduced in or relating directly to Satellite 6.13 Auto_Cherry_Picked Automatically cherrypicked PR using GHA No-CherryPick PR doesnt need CherryPick to previous branches labels Oct 3, 2023
@Satellite-QE
Copy link
Collaborator Author

trigger: test-robottelo
pytest: tests/foreman/maintain/test_service.py::test_positive_service_enable_disable

@Satellite-QE Satellite-QE added the AutoMerge_Cherry_Picked The cherrypicked PRs of master PR would be automerged if all checks passing label Oct 3, 2023
@Gauravtalreja1
Copy link
Collaborator

@Griffin-Sullivan from PRT failures, this requires changes from #12800, can you update both the PRs after your investigation?

@Gauravtalreja1 Gauravtalreja1 marked this pull request as draft October 4, 2023 08:07
@Griffin-Sullivan
Copy link
Contributor

trigger: test-robottelo
pytest: tests/foreman/maintain/test_service.py::test_positive_service_enable_disable

@Griffin-Sullivan Griffin-Sullivan marked this pull request as ready for review October 6, 2023 12:38
@Satellite-QE Satellite-QE merged commit a229b78 into 6.13.z Oct 6, 2023
22 of 23 checks passed
@Satellite-QE Satellite-QE deleted the cherry-pick-6.13.z-89b779b664e521b87b5ee999424c205369df965b branch October 6, 2023 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.13.z Introduced in or relating directly to Satellite 6.13 Auto_Cherry_Picked Automatically cherrypicked PR using GHA AutoMerge_Cherry_Picked The cherrypicked PRs of master PR would be automerged if all checks passing No-CherryPick PR doesnt need CherryPick to previous branches
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants