Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed test_positive_assign_http_proxy_to_products_repositories failure #12850

Merged
merged 1 commit into from
Oct 9, 2023
Merged

Fixed test_positive_assign_http_proxy_to_products_repositories failure #12850

merged 1 commit into from
Oct 9, 2023

Conversation

ColeHiggins2
Copy link
Member

This test was failing in stream due to not having an org and location selected.

@ColeHiggins2 ColeHiggins2 added UI Issues and PRs involving the UI No-CherryPick PR doesnt need CherryPick to previous branches Stream Introduced in or relating directly to Satellite Stream/Master labels Oct 9, 2023
@ColeHiggins2 ColeHiggins2 self-assigned this Oct 9, 2023
@ColeHiggins2 ColeHiggins2 requested a review from a team as a code owner October 9, 2023 19:20
@ColeHiggins2 ColeHiggins2 added the Easy Fix :) Easiest Fix to review and quick merge request. label Oct 9, 2023
@ColeHiggins2
Copy link
Member Author

trigger: test-robottelo
pytest: tests/foreman/ui/test_http_proxy.py::test_positive_assign_http_proxy_to_products_repositories

vsedmik
vsedmik approved these changes Oct 9, 2023
View reviewed changes
Copy link
Contributor

@vsedmik vsedmik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PRT pending

@Gauravtalreja1
Copy link
Collaborator

@ColeHiggins2 We should cherrypick this to older versions since this failure may also occur there?

sambible
sambible approved these changes Oct 9, 2023
View reviewed changes
Copy link
Contributor

@sambible sambible left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ack pending PRT and comment

damoore044
damoore044 approved these changes Oct 9, 2023
View reviewed changes
Copy link
Contributor

@damoore044 damoore044 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ack- prt pending

@ColeHiggins2
Copy link
Member Author

ColeHiggins2 commented Oct 9, 2023 •
edited
Loading

@Gauravtalreja1 this was originally just for stream... but now that you mention it, this test is failing in previous versions too. Looks like its the same error in jenkins ... Lets cherrypick into older versions and i can see if they pass

@ColeHiggins2 ColeHiggins2 added CherryPick PR needs CherryPick to previous branches 6.12.z Introduced in or relating directly to Satellite 6.12 6.13.z Introduced in or relating directly to Satellite 6.13 6.14.z Introduced in or relating directly to Satellite 6.14 and removed No-CherryPick PR doesnt need CherryPick to previous branches labels Oct 9, 2023
@Gauravtalreja1 Gauravtalreja1 added the AutoMerge_Cherry_Picked The cherrypicked PRs of master PR would be automerged if all checks passing label Oct 9, 2023
@Gauravtalreja1
Copy link
Collaborator

@ColeHiggins2 Thanks for confirming, I've seen this failure in your tests for http proxy earlier, that's why I remember it :)

@Gauravtalreja1 Gauravtalreja1 merged commit a0841b5 into SatelliteQE:master Oct 9, 2023
@Satellite-QE Satellite-QE mentioned this pull request Oct 9, 2023
Merged
github-actions bot pushed a commit that referenced this pull request Oct 9, 2023
@ColeHiggins2 @web-flow
Fixed test_positive_assign_http_proxy_to_products_repositories failure (
fa899db 
#12850)

final commit for test fixes

(cherry picked from commit a0841b5)
github-actions bot pushed a commit that referenced this pull request Oct 9, 2023
@ColeHiggins2 @web-flow
Fixed test_positive_assign_http_proxy_to_products_repositories failure (
a952290 
#12850)

final commit for test fixes

(cherry picked from commit a0841b5)
@Satellite-QE Satellite-QE mentioned this pull request Oct 9, 2023
Merged
github-actions bot pushed a commit that referenced this pull request Oct 9, 2023
@ColeHiggins2 @web-flow
Fixed test_positive_assign_http_proxy_to_products_repositories failure (
cb2de57 
#12850)

final commit for test fixes

(cherry picked from commit a0841b5)
@Satellite-QE Satellite-QE mentioned this pull request Oct 9, 2023
Merged
shweta83 pushed a commit to shweta83/robottelo that referenced this pull request Apr 10, 2024
@ColeHiggins2 @shweta83
Fixed test_positive_assign_http_proxy_to_products_repositories failure (
de391fd 
SatelliteQE#12850)

final commit for test fixes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@damoore044 damoore044 damoore044 approved these changes

@vsedmik vsedmik vsedmik approved these changes

@sambible sambible sambible approved these changes

@Gauravtalreja1 Gauravtalreja1 Awaiting requested review from Gauravtalreja1

Assignees

@ColeHiggins2 ColeHiggins2

Labels
6.12.z Introduced in or relating directly to Satellite 6.12 6.13.z Introduced in or relating directly to Satellite 6.13 6.14.z Introduced in or relating directly to Satellite 6.14 AutoMerge_Cherry_Picked The cherrypicked PRs of master PR would be automerged if all checks passing CherryPick PR needs CherryPick to previous branches Easy Fix :) Easiest Fix to review and quick merge request. Stream Introduced in or relating directly to Satellite Stream/Master UI Issues and PRs involving the UI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ColeHiggins2 @Gauravtalreja1 @sambible @vsedmik @damoore044