Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to errata-stream fix, use up to date register method for rhel_contenthost #12851

Merged
merged 3 commits into from
Oct 11, 2023

Conversation

damoore044
Copy link
Contributor

@damoore044 damoore044 commented Oct 9, 2023

Previous pr was merged just a bit before I could get this in. The old method works and passes,
but should use .register() going forward with the removal of katello-agent.

@damoore044 damoore044 requested review from a team as code owners October 9, 2023 20:00
@damoore044 damoore044 added No-CherryPick PR doesnt need CherryPick to previous branches Stream Introduced in or relating directly to Satellite Stream/Master labels Oct 9, 2023
@damoore044

This comment was marked as duplicate.

@damoore044 damoore044 added the Easy Fix :) Easiest Fix to review and quick merge request. label Oct 9, 2023
@damoore044

This comment was marked as duplicate.

activation_keys=ak.name,
lifecycle_environment=function_lce,
target=target_sat,
force=True,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess, without force=True contenthost registration should work.
Can you please try by removing this parameter?

@vijaysawant

This comment was marked as duplicate.

Copy link
Contributor

@vsedmik vsedmik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like sleep(20) is still not enough in some cases, rerun PRT

Copy link
Contributor

@vsedmik vsedmik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PRT rerun all passed this time 🤔
Looks good, just Vijay's comment is pending

tests/foreman/api/test_errata.py Outdated Show resolved Hide resolved
tests/foreman/api/test_errata.py Show resolved Hide resolved
tests/foreman/api/test_errata.py Outdated Show resolved Hide resolved
tests/foreman/api/test_errata.py Show resolved Hide resolved
tests/foreman/api/test_errata.py Show resolved Hide resolved
@damoore044

This comment was marked as duplicate.

@damoore044
Copy link
Contributor Author

damoore044 commented Oct 11, 2023

Passed [Build 4329]
trigger: test-robottelo
pytest: tests/foreman/api/test_errata.py -k test_positive_install_multiple_in_host

@damoore044
Copy link
Contributor Author

trigger: test-robottelo
pytest: tests/foreman/api/test_errata.py -k test_positive_install_multiple_in_host -cli-log-level=DEBUG

@Gauravtalreja1 Gauravtalreja1 merged commit 2799a3f into SatelliteQE:master Oct 11, 2023
5 checks passed
LadislavVasina1 pushed a commit that referenced this pull request Oct 20, 2023
…contenthost (#12851)

* Update to use .register() method, the preferred way without katello-agent

* Addressing comments

* subscription-manager repos call, local pass
shweta83 pushed a commit to shweta83/robottelo that referenced this pull request Apr 10, 2024
…contenthost (SatelliteQE#12851)

* Update to use .register() method, the preferred way without katello-agent

* Addressing comments

* subscription-manager repos call, local pass
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Easy Fix :) Easiest Fix to review and quick merge request. No-CherryPick PR doesnt need CherryPick to previous branches Stream Introduced in or relating directly to Satellite Stream/Master
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants