Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[6.14.z] Optional pytest Vault login and code nitpicking #12867

Merged
merged 1 commit into from
Oct 20, 2023
Merged

[6.14.z] Optional pytest Vault login and code nitpicking #12867

merged 1 commit into from
Oct 20, 2023

Conversation

Satellite-QE
Copy link
Collaborator

Cherrypick of PR: #12822

This PR brings optional logging to the vault from pytest session requested by the community.

  • Multiple options to bypass vault login, where pytest session won't insist on logging into Vault. :
    • No .env file
    • VAULT_ENABLED_FOR_DYNACONF option is set to False in .env file
    • Commented out VAULT_ENABLED_FOR_DYNACONFoption in.env` file
    • No VAULT_ENABLED_FOR_DYNACONF option in .env file
  • Also made some code nitpicking changes !

@Satellite-QE Satellite-QE added 6.14.z Introduced in or relating directly to Satellite 6.14 Auto_Cherry_Picked Automatically cherrypicked PR using GHA No-CherryPick PR doesnt need CherryPick to previous branches labels Oct 10, 2023
@Satellite-QE
Copy link
Collaborator Author

trigger: test-robottelo
pytest: tests/foreman/api/test_product.py

@yanpliu
Copy link
Contributor

yanpliu commented Oct 20, 2023

Can some one help to review and merge this PR? virt-who cases failed for the vault update, thanks.

@jyejare
Optional pytest Vault login and code nitpicking (#12822)
e97df5b 
* Optional pytest Vault login and code formating

* Multiple options supported for non-vault pytest session

(cherry picked from commit 9e85161)
@jyejare jyejare force-pushed the cherry-pick-6.14.z-9e851610c43e50ab8e472c1fd341394c0b16fd3c branch from 828a621 to e97df5b Compare October 20, 2023 08:01
@jyejare
Copy link
Member

jyejare commented Oct 20, 2023

@yanpliu Ok I am merging this PR after waiting for long as you and some of the folks are blocked due to it.

I have tested this locally it works as expected and PRT ran successfully already.

@jyejare jyejare enabled auto-merge (squash) October 20, 2023 08:02
@jyejare jyejare merged commit 14b9d17 into 6.14.z Oct 20, 2023
5 checks passed
@jyejare jyejare deleted the cherry-pick-6.14.z-9e851610c43e50ab8e472c1fd341394c0b16fd3c branch October 20, 2023 08:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jyejare jyejare

@Satellite-QE Satellite-QE

Labels
6.14.z Introduced in or relating directly to Satellite 6.14 Auto_Cherry_Picked Automatically cherrypicked PR using GHA No-CherryPick PR doesnt need CherryPick to previous branches
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Satellite-QE @yanpliu @jyejare