Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[6.13.z] Optional pytest Vault login and code nitpicking #12868

Merged
merged 1 commit into from
Oct 22, 2023
Merged

[6.13.z] Optional pytest Vault login and code nitpicking #12868

merged 1 commit into from
Oct 22, 2023

Conversation

Satellite-QE
Copy link
Collaborator

Cherrypick of PR: #12822

This PR brings optional logging to the vault from pytest session requested by the community.

  • Multiple options to bypass vault login, where pytest session won't insist on logging into Vault. :
    • No .env file
    • VAULT_ENABLED_FOR_DYNACONF option is set to False in .env file
    • Commented out VAULT_ENABLED_FOR_DYNACONFoption in.env` file
    • No VAULT_ENABLED_FOR_DYNACONF option in .env file
  • Also made some code nitpicking changes !

@jyejare @web-flow
Optional pytest Vault login and code nitpicking (#12822)
0da54db 
* Optional pytest Vault login and code formating

* Multiple options supported for non-vault pytest session

(cherry picked from commit 9e85161)
@Satellite-QE Satellite-QE added 6.13.z Introduced in or relating directly to Satellite 6.13 Auto_Cherry_Picked Automatically cherrypicked PR using GHA No-CherryPick PR doesnt need CherryPick to previous branches labels Oct 10, 2023
@Satellite-QE
Copy link
Collaborator Author

trigger: test-robottelo
pytest: tests/foreman/api/test_product.py

@lpramuk lpramuk mentioned this pull request Oct 22, 2023
Closed
@lpramuk
Copy link
Contributor

lpramuk commented Oct 22, 2023

trigger: test-robottelo
pytest: tests/foreman/api/test_repository_set.py

@lpramuk lpramuk merged commit 959b5bd into 6.13.z Oct 22, 2023
17 checks passed
@lpramuk lpramuk deleted the cherry-pick-6.13.z-9e851610c43e50ab8e472c1fd341394c0b16fd3c branch October 22, 2023 21:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lpramuk lpramuk lpramuk approved these changes

Assignees

@jyejare jyejare

@Satellite-QE Satellite-QE

Labels
6.13.z Introduced in or relating directly to Satellite 6.13 Auto_Cherry_Picked Automatically cherrypicked PR using GHA No-CherryPick PR doesnt need CherryPick to previous branches
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Satellite-QE @lpramuk @jyejare