-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add UEFI HTTP Boot provisioning test #12908
Add UEFI HTTP Boot provisioning test #12908
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK, looks good!
Could we please run PRT if possible for provisioning!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ack, great job @shubhamsg199
@jyejare PRT will skip this tests as he's using pytest.mark.skip_if_open("BZ:2242925")
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see no assertions that would test that the host is indeed being provisioned by HTTPBoot
.
Satellite used to deploy the pxelinux
and grub
config files along the others no matter what kind of OS bootloader you selected. So I am wondering whether the host is indeed using the HTTPBoot
here and not just falling back to any other method.
This test does not do any kind of introspection into the boot and installer procedures at all and simply blindly waits till the host build status is being flipped in satellite.
I'd personally expect more assertions especially in this area as there are several points where the provisioning might go wrong (invalid provisoning token being passed, proxy not reachable, rendered template being wrong,...).
Having a failed test of this kind, not knowing what happened sounds non-optimal to me.
I'd suggest to add some checkpoints, like listening to incoming HTTP requests to the HTTP proxy to ensure, that a correct request indeed arrived and that the proxy correctly responded to it.
We could as well issue the call to proxy manually and see if we get the properly rendered template with the given provisioning token (at least just log it or save it as an artifact for the eventual TFA).
Thoughts?
If we select |
598ab1a
to
8bf7d4f
Compare
Signed-off-by: Shubham Ganar <[email protected]>
8bf7d4f
to
c422bdc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for implementing it.
there are few more log patterns you might test down the road, e.g. request for the ks file, etc. but i am not going to block the PR on this.
thank you
Signed-off-by: Shubham Ganar <[email protected]> (cherry picked from commit cd2d2b0)
Signed-off-by: Shubham Ganar <[email protected]> (cherry picked from commit cd2d2b0)
Add UEFI HTTP Boot provisioning test (#12908) Signed-off-by: Shubham Ganar <[email protected]> (cherry picked from commit cd2d2b0) Co-authored-by: Shubham Ganar <[email protected]>
Add UEFI HTTP Boot provisioning test (#12908) Signed-off-by: Shubham Ganar <[email protected]> (cherry picked from commit cd2d2b0) Co-authored-by: Shubham Ganar <[email protected]>
Signed-off-by: Shubham Ganar <[email protected]>
Adding UEFI HTTP Boot provisioning test. The test will be skipped till the BZ#2242925 is fixed