Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add GitHub Pull request template (.md) file #12943

Merged
merged 3 commits into from
Oct 26, 2023

Conversation

vijaysawant
Copy link
Contributor

@vijaysawant vijaysawant commented Oct 19, 2023

Problem Statement

Most of Pull Requests doesn't have enough information in the description section to go over before starting the review process.

Solution

Proposed template help streamline the contribution PR generating process by providing guidance and well structured information.

More information

.github/new_pull_request.md template is used to provide guidance and structure to contributors when they create a pull request.

Related Reference links

GitHub docs create a PR template

Additional Notes

Proposed template has added basic information, request others to modify respective templates as per the requirement.

@vijaysawant vijaysawant requested a review from a team as a code owner October 19, 2023 13:37
@vijaysawant vijaysawant added the enhancement An addition to the robottelo framework label Oct 19, 2023
@vijaysawant vijaysawant marked this pull request as draft October 19, 2023 13:56
@vijaysawant vijaysawant changed the title add GitHub issue template (.yaml) and Pull request template (.md) files add GitHub Pull request template (.md) file Oct 20, 2023
@vijaysawant vijaysawant marked this pull request as ready for review October 20, 2023 15:03
Copy link
Contributor

@Griffin-Sullivan Griffin-Sullivan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not completely sold on the idea that we need a template. The main benefit would be the Problem Statement and Solution. Outside of that our main issue is inconsistent contributions which could be solved in refreshing our contributing documentation.

.github/new_pull_request.md Outdated Show resolved Hide resolved
.github/new_pull_request.md Outdated Show resolved Hide resolved
@Gauravtalreja1 Gauravtalreja1 added the No-CherryPick PR doesnt need CherryPick to previous branches label Oct 25, 2023
@JacobCallahan JacobCallahan merged commit 5a4dcdb into SatelliteQE:master Oct 26, 2023
5 checks passed
shweta83 pushed a commit to shweta83/robottelo that referenced this pull request Apr 10, 2024
* add GitHub issue template (.yaml) and Pull request template (.md) files

* final changes after reivew

* add example of PRT comment and remove checklist section
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement An addition to the robottelo framework No-CherryPick PR doesnt need CherryPick to previous branches
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants