-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add GitHub Pull request template (.md) file #12943
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vijaysawant
changed the title
add GitHub issue template (.yaml) and Pull request template (.md) files
add GitHub Pull request template (.md) file
Oct 20, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not completely sold on the idea that we need a template. The main benefit would be the Problem Statement
and Solution
. Outside of that our main issue is inconsistent contributions which could be solved in refreshing our contributing documentation.
Gauravtalreja1
added
the
No-CherryPick
PR doesnt need CherryPick to previous branches
label
Oct 25, 2023
jyejare
approved these changes
Oct 26, 2023
Griffin-Sullivan
approved these changes
Oct 26, 2023
JacobCallahan
approved these changes
Oct 26, 2023
shweta83
pushed a commit
to shweta83/robottelo
that referenced
this pull request
Apr 10, 2024
* add GitHub issue template (.yaml) and Pull request template (.md) files * final changes after reivew * add example of PRT comment and remove checklist section
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
enhancement
An addition to the robottelo framework
No-CherryPick
PR doesnt need CherryPick to previous branches
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem Statement
Most of Pull Requests doesn't have enough information in the description section to go over before starting the review process.
Solution
Proposed template help streamline the contribution PR generating process by providing guidance and well structured information.
More information
.github/new_pull_request.md
template is used to provide guidance and structure to contributors when they create a pull request.Related Reference links
GitHub docs create a PR template
Additional Notes
Proposed template has added basic information, request others to modify respective templates as per the requirement.