Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding the image config details in the docker config #12958

Merged

Conversation

devendra104
Copy link
Member

@devendra104 devendra104 commented Oct 20, 2023

Updating the image registry configuration details in the docker config template. These details will be necessary for communicating with hub using the image registry proxy. In the CI, we have raised the MR-1140 that contains all the required information.

@devendra104 devendra104 requested a review from a team as a code owner October 20, 2023 17:14
@devendra104 devendra104 marked this pull request as draft October 20, 2023 17:31
@devendra104 devendra104 changed the title Draft: Adding the image config details in the docker config Adding the image config details in the docker config Oct 20, 2023
@devendra104 devendra104 added 6.12.z Introduced in or relating directly to Satellite 6.12 6.13.z Introduced in or relating directly to Satellite 6.13 6.14.z Introduced in or relating directly to Satellite 6.14 Auto_Cherry_Picked Automatically cherrypicked PR using GHA labels Oct 20, 2023
Copy link
Member

@jyejare jyejare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@devendra104 Looks Good to me! Not sure why the PR in draft state btw!

Copy link
Member

@ColeHiggins2 ColeHiggins2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ack pending READY state

@devendra104 devendra104 marked this pull request as ready for review November 2, 2023 16:56
@devendra104 devendra104 force-pushed the docker_registry_update branch from bd8b089 to 679a03b Compare November 2, 2023 16:58
@devendra104 devendra104 added CherryPick PR needs CherryPick to previous branches and removed Auto_Cherry_Picked Automatically cherrypicked PR using GHA labels Nov 2, 2023
@Gauravtalreja1 Gauravtalreja1 merged commit ee1ee6a into SatelliteQE:master Nov 3, 2023
github-actions bot pushed a commit that referenced this pull request Nov 3, 2023
github-actions bot pushed a commit that referenced this pull request Nov 3, 2023
github-actions bot pushed a commit that referenced this pull request Nov 3, 2023
Gauravtalreja1 pushed a commit that referenced this pull request Nov 3, 2023
Adding the image config details in the docker config (#12958)

(cherry picked from commit ee1ee6a)

Co-authored-by: Devendra <[email protected]>
Gauravtalreja1 pushed a commit that referenced this pull request Nov 3, 2023
Adding the image config details in the docker config (#12958)

(cherry picked from commit ee1ee6a)

Co-authored-by: Devendra <[email protected]>
Gauravtalreja1 pushed a commit that referenced this pull request Nov 3, 2023
Adding the image config details in the docker config (#12958)

(cherry picked from commit ee1ee6a)

Co-authored-by: Devendra <[email protected]>
shweta83 pushed a commit to shweta83/robottelo that referenced this pull request Apr 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.12.z Introduced in or relating directly to Satellite 6.12 6.13.z Introduced in or relating directly to Satellite 6.13 6.14.z Introduced in or relating directly to Satellite 6.14 CherryPick PR needs CherryPick to previous branches
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants