Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix convert2rhel tests by CVV sort and other fixes #12959

Merged
merged 1 commit into from
Nov 7, 2023

Conversation

Gauravtalreja1
Copy link
Collaborator

@Gauravtalreja1 Gauravtalreja1 commented Oct 20, 2023

Description:

  1. For fetching latest CVV from CV we use index -1, and CVV list isn't sorted every time, so in such case, it tries to promote the older CVV which is already promoted and fails to promote again with below error.
2023-10-21 03:22:56 - nailgun.client - WARNING - Received HTTP 400 response: {"displayMessage":"Cannot promote environment out of sequence. Use force to bypass restriction.","errors":["Cannot promote environment out of sequence. Use force to bypass restriction."]}
  1. Add workaround for CentOS 8 to fetch archived contents from new vault mirror, as its EOL in end of 2021 and existing mirror contents are now moved to vault mirror.
  2. Use --releasever=8.4.2105 when updating packages using yum to avoid upgrading to latest CentOS 8.5, which causes C2R to fail later.

@Gauravtalreja1 Gauravtalreja1 added Easy Fix :) Easiest Fix to review and quick merge request. No-CherryPick PR doesnt need CherryPick to previous branches Stream Introduced in or relating directly to Satellite Stream/Master labels Oct 20, 2023
@Gauravtalreja1 Gauravtalreja1 self-assigned this Oct 20, 2023
@Gauravtalreja1 Gauravtalreja1 requested a review from a team as a code owner October 20, 2023 22:10
@Gauravtalreja1 Gauravtalreja1 force-pushed the fix-c2r-cvv-sort branch 3 times, most recently from 1c224d9 to 793873b Compare October 26, 2023 13:10
@Gauravtalreja1 Gauravtalreja1 changed the title Fix convert2rhel tests by CVV sort Fix convert2rhel tests by CVV sort and other fixes Oct 26, 2023
@Gauravtalreja1 Gauravtalreja1 added TestFailure Issues and PRs related to a test failing in automation CherryPick PR needs CherryPick to previous branches 6.12.z Introduced in or relating directly to Satellite 6.12 AutoMerge_Cherry_Picked The cherrypicked PRs of master PR would be automerged if all checks passing 6.13.z Introduced in or relating directly to Satellite 6.13 6.14.z Introduced in or relating directly to Satellite 6.14 and removed Easy Fix :) Easiest Fix to review and quick merge request. No-CherryPick PR doesnt need CherryPick to previous branches Stream Introduced in or relating directly to Satellite Stream/Master labels Oct 26, 2023
@Gauravtalreja1
Copy link
Collaborator Author

trigger: test-robottelo
pytest: tests/foreman/api/test_convert2rhel.py::test_convert2rhel_centos

@Gauravtalreja1
Copy link
Collaborator Author

trigger: test-robottelo
pytest: tests/foreman/api/test_convert2rhel.py::test_convert2rhel_centos

@Gauravtalreja1
Copy link
Collaborator Author

trigger: test-robottelo
pytest: tests/foreman/api/test_convert2rhel.py::test_convert2rhel_centos[centos8]
env:
  ROBOTTELO_content_host__centos8__vm__deploy_rhel_version: '8.5'

@Gauravtalreja1
Copy link
Collaborator Author

trigger: test-robottelo
pytest: tests/foreman/api/test_convert2rhel.py::test_convert2rhel_centos[centos8]
env:
  ROBOTTELO_content_host__centos8__vm__deploy_rhel_version: "'8.5'"

@ogajduse
Copy link
Member

ogajduse commented Nov 6, 2023

@Gauravtalreja1 you might want to try ROBOTTELO_content_host__centos8__vm__deploy_rhel_version: "@str 8.5"

@Gauravtalreja1
Copy link
Collaborator Author

trigger: test-robottelo
pytest: tests/foreman/api/test_convert2rhel.py::test_convert2rhel_centos[centos8]
env:
  ROBOTTELO_content_host__centos8__vm__deploy_rhel_version: "@str 8.5"

@Gauravtalreja1
Copy link
Collaborator Author

@ogajduse Thank you for the suggestion, but it didn't work either. I've opened a satqe-jenkins MR to bump this and it's merged, so will try that

@Gauravtalreja1
Copy link
Collaborator Author

trigger: test-robottelo
pytest: tests/foreman/api/test_convert2rhel.py::test_convert2rhel_centos[centos8]

@Gauravtalreja1 Gauravtalreja1 removed the CherryPick PR needs CherryPick to previous branches label Nov 6, 2023
@Gauravtalreja1 Gauravtalreja1 added Easy Fix :) Easiest Fix to review and quick merge request. Stream Introduced in or relating directly to Satellite Stream/Master No-CherryPick PR doesnt need CherryPick to previous branches and removed 6.12.z Introduced in or relating directly to Satellite 6.12 AutoMerge_Cherry_Picked The cherrypicked PRs of master PR would be automerged if all checks passing 6.13.z Introduced in or relating directly to Satellite 6.13 6.14.z Introduced in or relating directly to Satellite 6.14 labels Nov 6, 2023
Copy link
Contributor

@shweta83 shweta83 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ack.

Copy link
Contributor

@shubhamsg199 shubhamsg199 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ack

@shubhamsg199 shubhamsg199 merged commit c0971e5 into SatelliteQE:master Nov 7, 2023
7 of 14 checks passed
@Gauravtalreja1 Gauravtalreja1 deleted the fix-c2r-cvv-sort branch November 7, 2023 06:53
shweta83 pushed a commit to shweta83/robottelo that referenced this pull request Apr 10, 2024
Fix convert2rhel tests by CVV sort

Signed-off-by: Gaurav Talreja <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Easy Fix :) Easiest Fix to review and quick merge request. No-CherryPick PR doesnt need CherryPick to previous branches Stream Introduced in or relating directly to Satellite Stream/Master TestFailure Issues and PRs related to a test failing in automation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants