Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing flaky http proxy end to end test #12964

Closed
wants to merge 1 commit into from
Closed

Fixing flaky http proxy end to end test #12964

wants to merge 1 commit into from

Conversation

ColeHiggins2
Copy link
Member

test_positive_end_to_end has been a very flaky test.

This is a test PR to check to see if the test needs to have functional manifests and not module

@ColeHiggins2 ColeHiggins2 added CherryPick PR needs CherryPick to previous branches 6.12.z Introduced in or relating directly to Satellite 6.12 6.13.z Introduced in or relating directly to Satellite 6.13 6.14.z Introduced in or relating directly to Satellite 6.14 labels Oct 24, 2023
@ColeHiggins2 ColeHiggins2 self-assigned this Oct 24, 2023
@ColeHiggins2 ColeHiggins2 requested a review from a team as a code owner October 24, 2023 17:25
@vijaysawant
Copy link
Contributor

looks good to me 👍

adarshdubey-star
adarshdubey-star approved these changes Oct 25, 2023
View reviewed changes
Copy link
Contributor

@adarshdubey-star adarshdubey-star left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ack, codewise Let's have a PRT run.

@vsedmik
Copy link
Contributor

vsedmik commented Oct 26, 2023

trigger: test-robottelo
pytest: tests/foreman/api/test_http_proxy.py -k test_positive_end_to_end -n 3

vsedmik
vsedmik approved these changes Oct 26, 2023
View reviewed changes
Copy link
Contributor

@vsedmik vsedmik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK, PRT pending

@vijaysawant
Copy link
Contributor

trigger: test-robottelo
pytest: tests/foreman/api/test_http_proxy.py -k test_positive_end_to_end

@Gauravtalreja1 Gauravtalreja1 force-pushed the http_end_to_end_test_fix branch from 27dbda5 to 3d3bb90 Compare November 7, 2023 06:30
@Gauravtalreja1
Copy link
Collaborator

trigger: test-robottelo
pytest: tests/foreman/api/test_http_proxy.py -k test_positive_end_to_end

@ColeHiggins2
Copy link
Member Author

Closing due to fix in #13064

@ColeHiggins2
Copy link
Member Author

Closing due to fix in #13064

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adarshdubey-star adarshdubey-star adarshdubey-star approved these changes

@vsedmik vsedmik vsedmik approved these changes

Assignees

@ColeHiggins2 ColeHiggins2

Labels
6.12.z Introduced in or relating directly to Satellite 6.12 6.13.z Introduced in or relating directly to Satellite 6.13 6.14.z Introduced in or relating directly to Satellite 6.14 CherryPick PR needs CherryPick to previous branches
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ColeHiggins2 @vijaysawant @vsedmik @Gauravtalreja1 @adarshdubey-star