Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[6.13.z] Fix vault makescripts with capture output #12975

Merged
merged 1 commit into from
Oct 25, 2023
Merged

[6.13.z] Fix vault makescripts with capture output #12975

merged 1 commit into from
Oct 25, 2023

Conversation

Satellite-QE
Copy link
Collaborator

Cherrypick of PR: #12909

Missing Capture Output made make vault scripts to break as it was trying to read and print STDOUT which was never returned due to capture_output was not set.

Fix:

  • Set capture_output to True in subprocess running vault command.
  • Alter logging of some events to appropriate level.

This also addresses the REGEX for Vault_enablement key in .env when its the first line in .env file.

@jyejare @web-flow
Fix vault makescripts with capture output (#12909)
526c822 
* Fix vault makescripts with capture output

* Handle topped Vault enablement in .env file

(cherry picked from commit 291698f)
@Satellite-QE Satellite-QE added 6.13.z Introduced in or relating directly to Satellite 6.13 Auto_Cherry_Picked Automatically cherrypicked PR using GHA No-CherryPick PR doesnt need CherryPick to previous branches labels Oct 25, 2023
@Satellite-QE
Copy link
Collaborator Author

trigger: test-robottelo
pytest: tests/foreman/api/test_product.py -k test_positive_create_with_label

@jyejare jyejare enabled auto-merge (squash) October 25, 2023 15:30
@jyejare jyejare merged commit 43598ac into 6.13.z Oct 25, 2023
17 checks passed
@jyejare jyejare deleted the cherry-pick-6.13.z-291698f925eb7016ff7d11764b218e2c7cf995d4 branch October 25, 2023 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jyejare jyejare

Labels
6.13.z Introduced in or relating directly to Satellite 6.13 Auto_Cherry_Picked Automatically cherrypicked PR using GHA No-CherryPick PR doesnt need CherryPick to previous branches
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Satellite-QE @jyejare