Stream fix errata:UI (test_end_to_end) #12978

damoore044 · 2023-10-25T17:39:15Z

Refactor errata e2e with updated standards, contenthost through Global Registration, enable repositories with subscription manager.

Remove setting_update of remote_execution_by_default:True (BZ 2029192), this user setting has
been removed for 6.15.0, and by default is set to True.

Used request.addfinalizer for cleanup of entities modified in the new fixture registered_contenthost, to prevent conflicts between parameterized runs.
~~Depends on navigation fix in airgun 1018.~~ Merged

damoore044 · 2023-11-01T17:18:16Z

trigger: test-robottelo
pytest: tests/foreman/ui/test_errata.py -k test_end_to_end
airgun: 1018

tests/foreman/ui/test_errata.py

jeremylenz

A couple thoughts below, for what they're worth :)

In general we're moving away from the term "content host" in favor of simply "host."

tests/foreman/ui/test_errata.py

damoore044 · 2023-11-02T19:16:54Z

trigger: test-robottelo
pytest: tests/foreman/ui/test_errata.py -k test_end_to_end

tests/foreman/ui/test_errata.py

vsedmik · 2023-11-06T10:53:09Z

tests/foreman/ui/test_errata.py

+    _remove_client_package(registered_contenthost, FAKE_1_CUSTOM_PACKAGE_NAME)
+    assert _install_client_package(registered_contenthost, FAKE_1_CUSTOM_PACKAGE)
+    assert (
+        appl_errata := registered_contenthost.applicable_errata_count


PRT just blows my mind here with E assert 1 == 1
I though I understood how the walrus operator works, also locally this works. No idea what's wrong in PRT's python version walrus implementation. Maybe try without walrus.

@JacobCallahan and I had some discussion around this, there must be some sort of ambiguity in the assignment I am not seeing. I see success assigning the applicable_errata count first, and then arresting on the next line

Gauravtalreja1 · 2023-11-06T17:34:31Z

robottelo/cli/factory.py

+    assert len(cv_info['versions']) > 0
+    cvv = sorted(cvv['id'] for cvv in cv_info['versions'])[-1]


Non-blocking, Sorting is fine here, but why we're explicitly hitting this issue in stream(seen a couple of PRs for this), so just wondering if are you aware of any related changes in stream? @damoore044 @vsedmik @sambible

@Gauravtalreja1 The issue is not specific to stream, I've seen it in older versions before and this BZ was reported already. However, it feels to happen more frequently in stream - same passes in z-streams but fails in stream.

tests/foreman/ui/test_errata.py

damoore044 · 2023-11-07T23:24:26Z

trigger: test-robottelo
pytest: tests/foreman/ui/test_errata.py -k test_end_to_end

damoore044 · 2023-11-08T10:56:43Z

trigger: test-robottelo
pytest: tests/foreman/ui/test_errata.py -k test_end_to_end

vsedmik · 2023-11-09T14:20:54Z

trigger: test-robottelo
pytest: tests/foreman/ui/test_errata.py -k test_end_to_end

vsedmik · 2023-11-09T17:37:46Z

tests/foreman/ui/test_errata.py

+
+    @request.addfinalizer
+    # Cleanup for in between parameterized runs
+    def cleanup():


It looks that in this cleanup we just roll back all the changes so that we have the module-scoped fixtures (mostly module_cv) ready for the next RHEL contenthost (via parametrization). What is the idea behind this need? Isn't it just fine to go with function-scoped fixtures instead module-scoped?

I could switch them to function fixtures, but may not be a simple change.
Many of the errata tests already run using module scope fixtures, so was keeping those for consistency.

Ok, no worries, merged already.

damoore044 · 2023-11-10T17:01:44Z

Future Notes: Will probably also work without extensive cleanup, by using function-scoped cv fixture or custom.

Vlad made a good point today however- the teardown is nice testing to have, of a graceful cleanup of entities being used to host content w/ registered host. Could probably use some assertions at some point.

I wonder if we have any other testing around cleanup for content & entities of a reg. host? Looking into that

* Updates for UI errata e2e * Check bulk generate applicability task * Cleanup between parameterized runs * Addressing comments

This comment was marked as duplicate.

Sign in to view

damoore044 force-pushed the errata-stream-fix branch 5 times, most recently from e4e2074 to 6e85ba1 Compare October 27, 2023 17:16

This comment was marked as duplicate.

Sign in to view

damoore044 force-pushed the errata-stream-fix branch from 92b7d68 to 8b82989 Compare October 31, 2023 13:55

This comment was marked as duplicate.

Sign in to view

damoore044 force-pushed the errata-stream-fix branch 3 times, most recently from 307ea77 to 5b72ec4 Compare October 31, 2023 22:38

damoore044 added No-CherryPick PR doesnt need CherryPick to previous branches Stream Introduced in or relating directly to Satellite Stream/Master labels Oct 31, 2023

This comment was marked as duplicate.

Sign in to view

damoore044 marked this pull request as ready for review October 31, 2023 23:26

damoore044 requested review from a team as code owners October 31, 2023 23:26

github-actions bot assigned damoore044 Oct 31, 2023

damoore044 force-pushed the errata-stream-fix branch from 5b72ec4 to 5c7dbee Compare November 1, 2023 17:10

damoore044 mentioned this pull request Nov 1, 2023

New Host-Errata tab search fix SatelliteQE/airgun#1018

Merged

damoore044 requested review from sambible, ColeHiggins2, vijaysawant and vsedmik November 2, 2023 13:26

damoore044 force-pushed the errata-stream-fix branch from 5c7dbee to dcfad83 Compare November 2, 2023 15:00

This comment was marked as duplicate.

Sign in to view

JacobCallahan reviewed Nov 2, 2023

View reviewed changes

tests/foreman/ui/test_errata.py Outdated Show resolved Hide resolved

damoore044 force-pushed the errata-stream-fix branch from 8293c0d to 4a8e566 Compare November 2, 2023 15:42

This comment was marked as duplicate.

Sign in to view

JacobCallahan approved these changes Nov 2, 2023

View reviewed changes

jeremylenz reviewed Nov 2, 2023

View reviewed changes

tests/foreman/ui/test_errata.py Outdated Show resolved Hide resolved

tests/foreman/ui/test_errata.py Outdated Show resolved Hide resolved

damoore044 force-pushed the errata-stream-fix branch from 47eb1b2 to 459a1d0 Compare November 2, 2023 18:06

This comment was marked as duplicate.

Sign in to view

damoore044 force-pushed the errata-stream-fix branch from 459a1d0 to 00148f9 Compare November 2, 2023 19:14

vsedmik reviewed Nov 6, 2023

View reviewed changes

damoore044 force-pushed the errata-stream-fix branch 2 times, most recently from 6d79acb to 83cc4bc Compare November 6, 2023 15:16

Gauravtalreja1 reviewed Nov 6, 2023

View reviewed changes

damoore044 force-pushed the errata-stream-fix branch from 83cc4bc to 7c2fdf7 Compare November 7, 2023 23:09

damoore044 requested review from vsedmik and Gauravtalreja1 November 8, 2023 13:33

damoore044 added 4 commits November 8, 2023 14:38

Updates for UI errata e2e

365db43

Check bulk generate applicability task

effe759

Cleanup between parameterized runs

c2d21c2

Addressing comments

1ff2bc8

damoore044 force-pushed the errata-stream-fix branch from e4fcc46 to 1ff2bc8 Compare November 8, 2023 19:39

Griffin-Sullivan approved these changes Nov 9, 2023

View reviewed changes

Griffin-Sullivan merged commit 783549a into SatelliteQE:master Nov 9, 2023
6 checks passed

vsedmik reviewed Nov 9, 2023

View reviewed changes

shweta83 pushed a commit to shweta83/robottelo that referenced this pull request Apr 10, 2024

Stream fix errata:UI (test_end_to_end) (SatelliteQE#12978)

b60c321

* Updates for UI errata e2e * Check bulk generate applicability task * Cleanup between parameterized runs * Addressing comments

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Stream fix errata:UI (test_end_to_end) #12978

Stream fix errata:UI (test_end_to_end) #12978

damoore044 commented Oct 25, 2023 •

edited

Loading

This comment was marked as duplicate.

This comment was marked as duplicate.

This comment was marked as duplicate.

This comment was marked as duplicate.

damoore044 commented Nov 1, 2023

This comment was marked as duplicate.

This comment was marked as duplicate.

jeremylenz left a comment

This comment was marked as duplicate.

damoore044 commented Nov 2, 2023

vsedmik Nov 6, 2023

damoore044 Nov 7, 2023 •

edited

Loading

Gauravtalreja1 Nov 6, 2023

vsedmik Nov 7, 2023

damoore044 commented Nov 7, 2023

damoore044 commented Nov 8, 2023

vsedmik commented Nov 9, 2023

vsedmik Nov 9, 2023

damoore044 Nov 9, 2023

vsedmik Nov 9, 2023

damoore044 commented Nov 10, 2023 •

edited

Loading

		assert len(cv_info['versions']) > 0
		cvv = sorted(cvv['id'] for cvv in cv_info['versions'])[-1]

Stream fix errata:UI (test_end_to_end) #12978

Stream fix errata:UI (test_end_to_end) #12978

Conversation

damoore044 commented Oct 25, 2023 • edited Loading

This comment was marked as duplicate.

This comment was marked as duplicate.

This comment was marked as duplicate.

This comment was marked as duplicate.

damoore044 commented Nov 1, 2023

This comment was marked as duplicate.

This comment was marked as duplicate.

jeremylenz left a comment

Choose a reason for hiding this comment

This comment was marked as duplicate.

damoore044 commented Nov 2, 2023

vsedmik Nov 6, 2023

Choose a reason for hiding this comment

damoore044 Nov 7, 2023 • edited Loading

Choose a reason for hiding this comment

Gauravtalreja1 Nov 6, 2023

Choose a reason for hiding this comment

vsedmik Nov 7, 2023

Choose a reason for hiding this comment

damoore044 commented Nov 7, 2023

damoore044 commented Nov 8, 2023

vsedmik commented Nov 9, 2023

vsedmik Nov 9, 2023

Choose a reason for hiding this comment

damoore044 Nov 9, 2023

Choose a reason for hiding this comment

vsedmik Nov 9, 2023

Choose a reason for hiding this comment

damoore044 commented Nov 10, 2023 • edited Loading

damoore044 commented Oct 25, 2023 •

edited

Loading

damoore044 Nov 7, 2023 •

edited

Loading

damoore044 commented Nov 10, 2023 •

edited

Loading