Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sync RHOSP repos to capsule #12990

Merged
merged 1 commit into from
Oct 31, 2023
Merged

sync RHOSP repos to capsule #12990

merged 1 commit into from
Oct 31, 2023

Conversation

vijaysawant
Copy link
Contributor

Problem Statement

Closeloop around Bug #2154734 - openstack repos unable to sync on capsule

Solution

Added test case in tests/foreman/api/test_capsulecontent.py will create & sync rh openstack container repos on satellite and capsule

Related Issues

N/A

@vijaysawant vijaysawant added QETestCoverage Issues and PRs relating to a Satellite bug CherryPick PR needs CherryPick to previous branches AutoMerge_Cherry_Picked The cherrypicked PRs of master PR would be automerged if all checks passing 6.13.z Introduced in or relating directly to Satellite 6.13 6.14.z Introduced in or relating directly to Satellite 6.14 labels Oct 26, 2023
@vijaysawant vijaysawant force-pushed the close_loop_Pulp_BZ-2154734 branch 2 times, most recently from 6ebe177 to 4c8f5cd Compare October 27, 2023 13:32
@damoore044 damoore044 marked this pull request as ready for review October 27, 2023 17:51
@damoore044 damoore044 requested a review from a team as a code owner October 27, 2023 17:51
damoore044
damoore044 reviewed Oct 27, 2023
View reviewed changes
Copy link
Contributor

@damoore044 damoore044 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Quick question about repo sync-

@vijaysawant vijaysawant force-pushed the close_loop_Pulp_BZ-2154734 branch 2 times, most recently from 99157aa to 5803007 Compare October 28, 2023 17:44
@vijaysawant
Copy link
Contributor Author

trigger: test-robottelo
pytest: tests/foreman/api/test_capsulecontent.py -k test_positive_capsule_sync_openstack_container_repos

vsedmik
vsedmik requested changes Oct 30, 2023
View reviewed changes
Copy link
Contributor

@vsedmik vsedmik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor changes requested, otherwise looks good to me.

@vijaysawant vijaysawant force-pushed the close_loop_Pulp_BZ-2154734 branch 2 times, most recently from 6176d6b to 6cab817 Compare October 30, 2023 11:58
@vijaysawant
Copy link
Contributor Author

trigger: test-robottelo
pytest: tests/foreman/api/test_capsulecontent.py -k test_positive_capsule_sync_openstack_container_repos

@vsedmik
Copy link
Contributor

vsedmik commented Oct 30, 2023

oh maybe one thing - replace entities by target_sat.api

synkd
synkd approved these changes Oct 30, 2023
View reviewed changes
Copy link
Contributor

@synkd synkd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK, although I agree with @vsedmik that calls using entities should be replaced with target_sat.api.

@vijaysawant
Copy link
Contributor Author

ACK, although I agree with @vsedmik that calls using entities should be replaced with target_sat.api.

Okay. Let me change it quickly

@vijaysawant vijaysawant force-pushed the close_loop_Pulp_BZ-2154734 branch from 6cab817 to c5c2349 Compare October 31, 2023 06:53
@vijaysawant
Copy link
Contributor Author

trigger: test-robottelo
pytest: tests/foreman/api/test_capsulecontent.py -k test_positive_capsule_sync_openstack_container_repos

@vsedmik vsedmik merged commit ad95132 into SatelliteQE:master Oct 31, 2023
@Satellite-QE Satellite-QE mentioned this pull request Oct 31, 2023
Merged
github-actions bot pushed a commit that referenced this pull request Oct 31, 2023
@vijaysawant @web-flow
sync RHOSP repos to capsule (#12990)
2ed9188 
(cherry picked from commit ad95132)
github-actions bot pushed a commit that referenced this pull request Oct 31, 2023
@vijaysawant @web-flow
sync RHOSP repos to capsule (#12990)
896637b 
(cherry picked from commit ad95132)
@Satellite-QE Satellite-QE mentioned this pull request Oct 31, 2023
Merged
adarshdubey-star pushed a commit that referenced this pull request Oct 31, 2023
@Satellite-QE @vijaysawant
[6.13.z] sync RHOSP repos to capsule (#13006)
7cd620b 
sync RHOSP repos to capsule (#12990)

(cherry picked from commit ad95132)

Co-authored-by: vijay sawant <[email protected]>
adarshdubey-star pushed a commit that referenced this pull request Oct 31, 2023
@Satellite-QE @vijaysawant
[6.14.z] sync RHOSP repos to capsule (#13007)
9315588 
sync RHOSP repos to capsule (#12990)

(cherry picked from commit ad95132)

Co-authored-by: vijay sawant <[email protected]>
shweta83 pushed a commit to shweta83/robottelo that referenced this pull request Apr 10, 2024
@vijaysawant @shweta83
sync RHOSP repos to capsule (SatelliteQE#12990)
385685f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vsedmik vsedmik vsedmik approved these changes

@synkd synkd synkd approved these changes

@damoore044 damoore044 damoore044 approved these changes

Assignees

@vijaysawant vijaysawant

Labels
6.13.z Introduced in or relating directly to Satellite 6.13 6.14.z Introduced in or relating directly to Satellite 6.14 AutoMerge_Cherry_Picked The cherrypicked PRs of master PR would be automerged if all checks passing CherryPick PR needs CherryPick to previous branches QETestCoverage Issues and PRs relating to a Satellite bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@vijaysawant @vsedmik @synkd @damoore044