Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Discovery Provisioning UI coverage #12991

Merged
merged 1 commit into from
Nov 21, 2023
Merged

Discovery Provisioning UI coverage #12991

merged 1 commit into from
Nov 21, 2023

Conversation

adarshdubey-star
Copy link
Contributor

Adding UI coverage for Discovery provisioning scenarios.

@adarshdubey-star adarshdubey-star added UI Issues and PRs involving the UI CherryPick PR needs CherryPick to previous branches 6.13.z Introduced in or relating directly to Satellite 6.13 6.14.z Introduced in or relating directly to Satellite 6.14 labels Oct 26, 2023
@adarshdubey-star adarshdubey-star self-assigned this Oct 26, 2023
@adarshdubey-star adarshdubey-star requested review from a team as code owners October 26, 2023 14:20
@adarshdubey-star adarshdubey-star force-pushed the discovery_ui branch 4 times, most recently from 25a8943 to b9f750c Compare October 27, 2023 06:57
@adarshdubey-star
Copy link
Contributor Author

trigger: test-robottelo
pytest: tests/foreman/ui/test_discoveredhost.py -k test_positive_auto_provision_host_with_rule
provisioning: true

@adarshdubey-star
Copy link
Contributor Author

trigger: test-robottelo
pytest: tests/foreman/ui/test_discoveredhost.py -k test_positive_provision_pxe_host
provisioning: true

@adarshdubey-star
Copy link
Contributor Author

trigger: test-robottelo
pytest: tests/foreman/ui/test_discoveredhost.py -k test_positive_provision_pxe_host
provisioning: true

2 similar comments
@adarshdubey-star
Copy link
Contributor Author

trigger: test-robottelo
pytest: tests/foreman/ui/test_discoveredhost.py -k test_positive_provision_pxe_host
provisioning: true

@adarshdubey-star
Copy link
Contributor Author

trigger: test-robottelo
pytest: tests/foreman/ui/test_discoveredhost.py -k test_positive_provision_pxe_host
provisioning: true

@adarshdubey-star
Copy link
Contributor Author

trigger: test-robottelo
pytest: tests/foreman/ui/test_discoveredhost.py -k test_positive_provision_pxe_host
provisioning: true
pod_resources_size: extra_large

1 similar comment
@adarshdubey-star
Copy link
Contributor Author

trigger: test-robottelo
pytest: tests/foreman/ui/test_discoveredhost.py -k test_positive_provision_pxe_host
provisioning: true
pod_resources_size: extra_large

vijaysawant
vijaysawant reviewed Oct 30, 2023
View reviewed changes
Copy link
Contributor

@vijaysawant vijaysawant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shall we add test steps for the modified tests along with chages? one can easily relate execution flow & test steps before starting with reivew or contribution.

@adarshdubey-star
Copy link
Contributor Author

Shall we add test steps for the modified tests along with chages? one can easily relate execution flow & test steps before starting with reivew or contribution.

The test steps are already there in the tests :)

@vijaysawant
Copy link
Contributor

Shall we add test steps for the modified tests along with chages? one can easily relate execution flow & test steps before starting with reivew or contribution.

The test steps are already there in the tests :)

Yea, seems like only test_positive_provision_pxe_host has steps present

@adarshdubey-star
Copy link
Contributor Author

The failing PRT is not because of the changes in the PR.

@adarshdubey-star
Copy link
Contributor Author

Shall we add test steps for the modified tests along with chages? one can easily relate execution flow & test steps before starting with reivew or contribution.

The test steps are already there in the tests :)

Yea, seems like only test_positive_provision_pxe_host has steps present

Yes those are the one-liners there @vijaysawant

Gauravtalreja1
Gauravtalreja1 reviewed Nov 7, 2023
View reviewed changes
tests/foreman/ui/test_discoveredhost.py Outdated Show resolved Hide resolved
tests/foreman/ui/test_discoveredhost.py Outdated Show resolved Hide resolved
tests/foreman/ui/test_discoveredhost.py Show resolved Hide resolved
tests/foreman/ui/test_discoveredhost.py Show resolved Hide resolved
pytest_fixtures/component/discovery.py Outdated Show resolved Hide resolved
tests/foreman/ui/test_discoveredhost.py Outdated Show resolved Hide resolved
tests/foreman/ui/test_discoveredhost.py Show resolved Hide resolved
@Gauravtalreja1 Gauravtalreja1 added the AutoMerge_Cherry_Picked The cherrypicked PRs of master PR would be automerged if all checks passing label Nov 21, 2023
@Gauravtalreja1 Gauravtalreja1 merged commit e803cc4 into SatelliteQE:master Nov 21, 2023
6 checks passed
@Satellite-QE Satellite-QE mentioned this pull request Nov 21, 2023
Merged
github-actions bot pushed a commit that referenced this pull request Nov 21, 2023
@adarshdubey-star @web-flow
Discovery Provisioning UI coverage (#12991)
d5f5604 
(cherry picked from commit e803cc4)
@Satellite-QE Satellite-QE mentioned this pull request Nov 21, 2023
Merged
github-actions bot pushed a commit that referenced this pull request Nov 21, 2023
@adarshdubey-star @web-flow
Discovery Provisioning UI coverage (#12991)
8ddda8b 
(cherry picked from commit e803cc4)
Gauravtalreja1 pushed a commit that referenced this pull request Nov 22, 2023
@Satellite-QE @adarshdubey-star
[6.14.z] Discovery Provisioning UI coverage (#13139)
62fae3c 
Discovery Provisioning UI coverage (#12991)

(cherry picked from commit e803cc4)

Co-authored-by: Adarsh dubey <[email protected]>
Gauravtalreja1 pushed a commit that referenced this pull request Nov 22, 2023
@Satellite-QE @adarshdubey-star
[6.13.z] Discovery Provisioning UI coverage (#13140)
0c0cc8c 
Discovery Provisioning UI coverage (#12991)

(cherry picked from commit e803cc4)

Co-authored-by: Adarsh dubey <[email protected]>
shweta83 pushed a commit to shweta83/robottelo that referenced this pull request Apr 10, 2024
@adarshdubey-star @shweta83
Discovery Provisioning UI coverage (SatelliteQE#12991)
c08597a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Gauravtalreja1 Gauravtalreja1 Gauravtalreja1 approved these changes

@shweta83 shweta83 Awaiting requested review from shweta83

@shubhamsg199 shubhamsg199 Awaiting requested review from shubhamsg199

@vijaysawant vijaysawant Awaiting requested review from vijaysawant

Assignees

@adarshdubey-star adarshdubey-star

Labels
6.13.z Introduced in or relating directly to Satellite 6.13 6.14.z Introduced in or relating directly to Satellite 6.14 AutoMerge_Cherry_Picked The cherrypicked PRs of master PR would be automerged if all checks passing CherryPick PR needs CherryPick to previous branches UI Issues and PRs involving the UI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@adarshdubey-star @vijaysawant @Gauravtalreja1