Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add automation for BZ 2243679 #13000

Merged
merged 1 commit into from
Oct 30, 2023
Merged

Add automation for BZ 2243679 #13000

merged 1 commit into from
Oct 30, 2023

Conversation

shubhamsg199
Copy link
Contributor

Add closed loop automation for BZ 2243679

@shubhamsg199 shubhamsg199 added CherryPick PR needs CherryPick to previous branches AutoMerge_Cherry_Picked The cherrypicked PRs of master PR would be automerged if all checks passing Stream Introduced in or relating directly to Satellite Stream/Master labels Oct 27, 2023
@shubhamsg199 shubhamsg199 self-assigned this Oct 27, 2023
@shubhamsg199 shubhamsg199 requested a review from a team as a code owner October 27, 2023 13:36
@shubhamsg199 shubhamsg199 marked this pull request as draft October 27, 2023 13:37
@shubhamsg199
Copy link
Contributor Author

trigger: test-robottelo
pytest: tests/foreman/api/test_provisioningtemplate.py::TestProvisioningTemplate::test_positive_template_check_remote_execution_snippet

@shubhamsg199 shubhamsg199 force-pushed the closed_loop_2243679 branch 2 times, most recently from 3d687b0 to 408ab61 Compare October 27, 2023 18:05
@shubhamsg199
Copy link
Contributor Author

trigger: test-robottelo
pytest: tests/foreman/api/test_provisioningtemplate.py::TestProvisioningTemplate::test_positive_template_check_remote_execution_snippet

@shubhamsg199 shubhamsg199 marked this pull request as ready for review October 27, 2023 19:03
adarshdubey-star
adarshdubey-star approved these changes Oct 30, 2023
View reviewed changes
Copy link
Contributor

@adarshdubey-star adarshdubey-star left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ack

vijaysawant
vijaysawant reviewed Oct 30, 2023
View reviewed changes
Copy link
Contributor

@vijaysawant vijaysawant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shall we add test steps for test case?
It would be easy to related work flow & execution steps of provisioning to any new one.

Gauravtalreja1
Gauravtalreja1 reviewed Oct 30, 2023
View reviewed changes
tests/foreman/api/test_provisioningtemplate.py Outdated Show resolved Hide resolved
tests/foreman/api/test_provisioningtemplate.py Outdated Show resolved Hide resolved
tests/foreman/api/test_provisioningtemplate.py Outdated Show resolved Hide resolved
tests/foreman/api/test_provisioningtemplate.py Show resolved Hide resolved
tests/foreman/api/test_provisioningtemplate.py Outdated Show resolved Hide resolved
@shubhamsg199 shubhamsg199 force-pushed the closed_loop_2243679 branch 2 times, most recently from 83dd983 to 88d2846 Compare October 30, 2023 11:54
@shubhamsg199
Copy link
Contributor Author

trigger: test-robottelo
pytest: tests/foreman/api/test_provisioningtemplate.py::TestProvisioningTemplate::test_positive_template_check_rex_snippet

@shubhamsg199
Closed loop BZ#2243679
e29a570 
Signed-off-by: Shubham Ganar <[email protected]>
@shubhamsg199
Copy link
Contributor Author

trigger: test-robottelo
pytest: tests/foreman/api/test_provisioningtemplate.py::TestProvisioningTemplate::test_positive_template_check_rex_snippet

@Gauravtalreja1 Gauravtalreja1 removed the AutoMerge_Cherry_Picked The cherrypicked PRs of master PR would be automerged if all checks passing label Oct 30, 2023
Gauravtalreja1
Gauravtalreja1 approved these changes Oct 30, 2023
View reviewed changes
Copy link
Collaborator

@Gauravtalreja1 Gauravtalreja1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ack, Great job @shubhamsg199
There's cherrypick label added here but BZ seem to be fixed in stream, and not in older versions, so do you intend to cherrypick it as is?
OR would you prefer remove single assert added as fix for the BZ, and then cherypick it in separate PR for 6.14.z?

@shubhamsg199 shubhamsg199 removed the CherryPick PR needs CherryPick to previous branches label Oct 30, 2023
@shubhamsg199
Copy link
Contributor Author

Right @Gauravtalreja1, I've removed the cherrypick label. Let's get this in for stream.
I will open a separate PR for automation for rex_snippet on older branches

@shubhamsg199 shubhamsg199 added the No-CherryPick PR doesnt need CherryPick to previous branches label Oct 30, 2023
@Gauravtalreja1 Gauravtalreja1 added the QETestCoverage Issues and PRs relating to a Satellite bug label Oct 30, 2023
@Gauravtalreja1 Gauravtalreja1 enabled auto-merge (squash) October 30, 2023 15:46
@Gauravtalreja1 Gauravtalreja1 merged commit dcf83d8 into SatelliteQE:master Oct 30, 2023
8 of 9 checks passed
shweta83 pushed a commit to shweta83/robottelo that referenced this pull request Apr 10, 2024
@shubhamsg199 @shweta83
Add automation for BZ 2243679 (SatelliteQE#13000)
c30f217 
Closed loop BZ#2243679

Signed-off-by: Shubham Ganar <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vijaysawant vijaysawant vijaysawant left review comments

@adarshdubey-star adarshdubey-star adarshdubey-star approved these changes

@Gauravtalreja1 Gauravtalreja1 Gauravtalreja1 approved these changes

Assignees

@shubhamsg199 shubhamsg199

Labels
No-CherryPick PR doesnt need CherryPick to previous branches QETestCoverage Issues and PRs relating to a Satellite bug Stream Introduced in or relating directly to Satellite Stream/Master
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@shubhamsg199 @Gauravtalreja1 @vijaysawant @adarshdubey-star