Check if VAULT_ADDR env var exists before deleting it #13016
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
|
Setting the VAULT_ADDR is mandatory and is being done in Context manager itself. Whats unsetting that var for you ? |
|
I still had some dummy values set in .env file for That is why it executed that path. |
jyejare
added
CherryPick
jyejare
approved these changes
Nov 2, 2023
github-actions bot
pushed a commit
that referenced
this pull request
Nov 2, 2023
Co-authored-by: dosas <[email protected]> (cherry picked from commit c1d7b42)
This was referenced Nov 2, 2023
github-actions bot
pushed a commit
that referenced
this pull request
Nov 2, 2023
Co-authored-by: dosas <[email protected]> (cherry picked from commit c1d7b42)
github-actions bot
pushed a commit
that referenced
this pull request
Nov 2, 2023
Co-authored-by: dosas <[email protected]> (cherry picked from commit c1d7b42)
Gauravtalreja1
pushed a commit
that referenced
this pull request
Nov 2, 2023
Check if VAULT_ADDR env var exists before deleting it (#13016) Co-authored-by: dosas <[email protected]> (cherry picked from commit c1d7b42) Co-authored-by: dosas <[email protected]>
Gauravtalreja1
pushed a commit
that referenced
this pull request
Nov 2, 2023
Check if VAULT_ADDR env var exists before deleting it (#13016) Co-authored-by: dosas <[email protected]> (cherry picked from commit c1d7b42) Co-authored-by: dosas <[email protected]>
Gauravtalreja1
pushed a commit
that referenced
this pull request
Nov 2, 2023
Check if VAULT_ADDR env var exists before deleting it (#13016) Co-authored-by: dosas <[email protected]> (cherry picked from commit c1d7b42) Co-authored-by: dosas <[email protected]>
shweta83
pushed a commit
to shweta83/robottelo
that referenced
this pull request
Apr 10, 2024
) Co-authored-by: dosas <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently this throws an error in teardown if
VAULT_ADDRis not set.