Remove BROKER_DIRECTORY from robottelo config #13027
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JacobCallahan
added
CherryPick
This is something that broker handles on its own and, due to import timing, isn't handled correctly in robottelo anyway. Removing the field and config mechanism should eliminate confusion around this behavior.
jyejare
reviewed
Nov 2, 2023
| # The path where your broker settings and inventory are located | ||
| # If you leave it blank, the default is the output of `broker --version` | ||
| BROKER_DIRECTORY: | ||
| # Broker has its own config which you can find by running `broker --version` |
There was a problem hiding this comment.
Many of us generally likes to keep conf files in robottelo root directory, so what if we could have made a broker to choose the conf file path rather than keeping it at fixed location.
There was a problem hiding this comment.
you can do that today, but it still wouldn't work correctly with robottelo setting it. just export BROKER_DIRECTORY=/path/to/robottelo
ColeHiggins2
approved these changes
Nov 2, 2023
vsedmik
approved these changes
Nov 14, 2023
This was referenced Nov 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is something that broker handles on its own and, due to import timing, isn't handled correctly in robottelo anyway. Removing the field and config mechanism should eliminate confusion around this behavior.