Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[6.15] Add test coverage for setting display_fqdn_for_hosts #13056

Merged

Conversation

Gauravtalreja1
Copy link
Collaborator

Description:

Add QE test coverage for new setting display_fqdn_for_hosts, which is renamed from append_domain_name_for_hosts

Related Issues

trigger: test-robottelo
pytest: tests/foreman/ui/test_settings.py -k test_positive_setting_display_fqdn_for_hosts

@Gauravtalreja1 Gauravtalreja1 added UI Issues and PRs involving the UI QETestCoverage Issues and PRs relating to a Satellite bug No-CherryPick PR doesnt need CherryPick to previous branches Stream Introduced in or relating directly to Satellite Stream/Master labels Nov 8, 2023
@Gauravtalreja1 Gauravtalreja1 self-assigned this Nov 8, 2023
@Gauravtalreja1 Gauravtalreja1 requested a review from a team as a code owner November 8, 2023 07:43
@Gauravtalreja1
Copy link
Collaborator Author

trigger: test-robottelo
pytest: tests/foreman/ui/test_settings.py -k test_positive_setting_display_fqdn_for_hosts

Copy link
Contributor

@Griffin-Sullivan Griffin-Sullivan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this Do Not Merge?

@adarshdubey-star
Copy link
Contributor

Why is this Do Not Merge?

I believe this coverage is related to an upcoming feature, it might require more testing or a change in the testing approach

@Gauravtalreja1
Copy link
Collaborator Author

@Griffin-Sullivan @adarshdubey-star you're right, I was looking for Dev's opinion on this, currently foreman code is in stream but katello isn't, and this test exercises foreman part correctly, but doesn't involve katello related part testing, so will open a separate PR to handle it later and would request to merge this as is

Copy link
Contributor

@adarshdubey-star adarshdubey-star left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ack

@adarshdubey-star adarshdubey-star merged commit 339bf1c into SatelliteQE:master Nov 10, 2023
12 checks passed
@Gauravtalreja1 Gauravtalreja1 deleted the close-loop-append-domain branch November 10, 2023 11:30
shweta83 pushed a commit to shweta83/robottelo that referenced this pull request Apr 10, 2024
…eQE#13056)

Add test coverage for setting display_fqdn_for_hosts

Signed-off-by: Gaurav Talreja <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
No-CherryPick PR doesnt need CherryPick to previous branches QETestCoverage Issues and PRs relating to a Satellite bug Stream Introduced in or relating directly to Satellite Stream/Master UI Issues and PRs involving the UI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants