-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[6.15] Add test coverage for setting display_fqdn_for_hosts #13056
[6.15] Add test coverage for setting display_fqdn_for_hosts #13056
Conversation
Signed-off-by: Gaurav Talreja <[email protected]>
trigger: test-robottelo |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is this Do Not Merge?
I believe this coverage is related to an upcoming feature, it might require more testing or a change in the testing approach |
@Griffin-Sullivan @adarshdubey-star you're right, I was looking for Dev's opinion on this, currently foreman code is in stream but katello isn't, and this test exercises foreman part correctly, but doesn't involve katello related part testing, so will open a separate PR to handle it later and would request to merge this as is |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ack
…eQE#13056) Add test coverage for setting display_fqdn_for_hosts Signed-off-by: Gaurav Talreja <[email protected]>
Description:
Add QE test coverage for new setting display_fqdn_for_hosts, which is renamed from append_domain_name_for_hosts
Related Issues
trigger: test-robottelo
pytest: tests/foreman/ui/test_settings.py -k test_positive_setting_display_fqdn_for_hosts