[6.13.z] Add Ruff pytest standards #13062
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JacobCallahan
added
No-CherryPick
| @@ -293,7 +293,7 @@ def test_positive_sync_proxy_with_certificate(request, target_sat, module_org, m | |||
| # Create and fetch new cerfiticate | |||
| target_sat.custom_cert_generate(proxy_host) | |||
| cacert = target_sat.execute(f'cat {cacert_path}').stdout | |||
| assert 'BEGIN CERTIFICATE' and 'END CERTIFICATE' in cacert | |||
| assert 'END CERTIFICATE' in cacert | |||
There was a problem hiding this comment.
We're missing assertion for 'BEGIN CERTIFICATE' here!
There was a problem hiding this comment.
That shouldn't be a concern since the master branch contains an identical patch. See this patch.
There was a problem hiding this comment.
Correct, this was a decision from the test owner.
There was a problem hiding this comment.
Cool, it's good to have but as @damoore044 confirmed this, so I wouldn't block on this
ogajduse
approved these changes
Nov 15, 2023
This is a big one! Most of the changes are automatic, but a number of these are manual. I've deselected rules relating to fixture naming, but we can have a conversation later about whether we want to adopt the underscore naming conventions for fixtures.
JacobCallahan
force-pushed
the
6.13.z
branch
from
eb832c0 to
40e2319
Compare
Gauravtalreja1
approved these changes
Nov 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a big one! Most of the changes are automatic, but a number of these are manual. I've deselected rules relating to fixture naming, but we can have a conversation later about whether we want to adopt the underscore naming conventions for fixtures.
fixes #13038