Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add test for satellite package removal #13065

Merged
merged 2 commits into from
Nov 15, 2023
Merged

Add test for satellite package removal #13065

merged 2 commits into from
Nov 15, 2023

Conversation

Griffin-Sullivan
Copy link
Contributor

Problem Statement

Customer case automation missing for https://bugzilla.redhat.com/show_bug.cgi?id=1884395.

Solution

Add a test for making sure you can't delete satellite / satellite-capsule and its dependencies.

Related Issues

None

@Griffin-Sullivan Griffin-Sullivan requested a review from a team as a code owner November 8, 2023 19:43
@Griffin-Sullivan
Copy link
Contributor Author

trigger: test-robottelo
pytest: tests/foreman/destructive/test_packages.py::test_negative_remove_satellite_packages

@Griffin-Sullivan Griffin-Sullivan added No-CherryPick PR doesnt need CherryPick to previous branches Stream Introduced in or relating directly to Satellite Stream/Master QETestCoverage Issues and PRs relating to a Satellite bug labels Nov 8, 2023
@Griffin-Sullivan
Copy link
Contributor Author

Griffin-Sullivan commented Nov 8, 2023 •
edited
Loading

I also just realized that the include_capsule mark requires sat_maintain to be used. I'll have to manually cherry-pick some of these changes to other branches too.

@Griffin-Sullivan
Copy link
Contributor Author

trigger: test-robottelo
pytest: tests/foreman/destructive/test_packages.py

adarshdubey-star
adarshdubey-star approved these changes Nov 9, 2023
View reviewed changes
Copy link
Contributor

@adarshdubey-star adarshdubey-star left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ack , code-wise

@Griffin-Sullivan Griffin-Sullivan marked this pull request as draft November 9, 2023 15:01
@Griffin-Sullivan
Copy link
Contributor Author

all_packages_update test worked fine. Rerunning for the new test here.

@Griffin-Sullivan
Copy link
Contributor Author

trigger: test-robottelo
pytest: tests/foreman/destructive/test_packages.py::test_negative_remove_satellite_packages

@synkd
Copy link
Contributor

synkd commented Nov 9, 2023

@Griffin-Sullivan can you rebase and then we'll get this merged?

@Griffin-Sullivan Griffin-Sullivan marked this pull request as ready for review November 9, 2023 18:25
@Griffin-Sullivan
Copy link
Contributor Author

@synkd should be good after checks

@ogajduse ogajduse merged commit 5405d12 into SatelliteQE:master Nov 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ogajduse ogajduse ogajduse approved these changes

@synkd synkd synkd approved these changes

@adarshdubey-star adarshdubey-star adarshdubey-star approved these changes

Assignees

@Griffin-Sullivan Griffin-Sullivan

Labels
No-CherryPick PR doesnt need CherryPick to previous branches QETestCoverage Issues and PRs relating to a Satellite bug Stream Introduced in or relating directly to Satellite Stream/Master
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Griffin-Sullivan @synkd @ogajduse @adarshdubey-star