Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[6.12.z] removing the import entities from nailgun and moving target_sat #13067

Merged

Conversation

omkarkhatavkar
Copy link

Problem Statement

Needs to be a cherrypick of #12989 to 6.12.z

Solution

This PR helps to do the cherrypick #12989

@omkarkhatavkar omkarkhatavkar changed the title removing the import entities from nailgun and moving target_sat [6.12.z] removing the import entities from nailgun and moving target_sat Nov 9, 2023
@omkarkhatavkar omkarkhatavkar added the No-CherryPick PR doesnt need CherryPick to previous branches label Nov 9, 2023
@omkarkhatavkar omkarkhatavkar force-pushed the cherrypick_update_target_sat_6_12 branch from f39090a to 5887a71 Compare November 9, 2023 15:28
@omkarkhatavkar
Copy link
Author

trigger: test-robottelo
pod_resource_size: extra_large

@ogajduse
Copy link
Member

Files that still contain from nailgun import entities:

pytest_fixtures/component/computeprofile.py
pytest_fixtures/component/hostgroup.py
pytest_fixtures/component/host.py
pytest_fixtures/component/oscap.py
pytest_fixtures/component/os.py
pytest_fixtures/component/provisioning_template.py
pytest_fixtures/component/repository.py
pytest_fixtures/component/satellite_auth.py
pytest_fixtures/component/subnet.py
pytest_fixtures/component/user_role.py
robottelo/config/__init__.py
robottelo/constants/__init__.py
robottelo/hosts.py
robottelo/utils/virtwho.py
scripts/graph_entities.py
tests/foreman/api/test_errata.py
tests/foreman/api/test_permission.py
tests/foreman/cli/test_contentaccess.py
tests/foreman/cli/test_contentview.py
tests/foreman/cli/test_errata.py
tests/foreman/cli/test_hostgroup.py
tests/foreman/cli/test_ldapauthsource.py
tests/foreman/cli/test_logging.py
tests/foreman/cli/test_oscap.py
tests/foreman/cli/test_ostreebranch.py
tests/foreman/cli/test_remoteexecution.py
tests/foreman/cli/test_repository.py
tests/foreman/cli/test_subscription.py
tests/foreman/cli/test_syncplan.py
tests/foreman/cli/test_templatesync.py
tests/foreman/cli/test_user.py
tests/foreman/longrun/test_inc_updates.py
tests/foreman/longrun/test_oscap.py
tests/foreman/ui/test_activationkey.py
tests/foreman/ui/test_architecture.py
tests/foreman/ui/test_audit.py
tests/foreman/ui/test_bookmarks.py
tests/foreman/ui/test_computeprofiles.py
tests/foreman/ui/test_computeresource_ec2.py
tests/foreman/ui/test_computeresource.py
tests/foreman/ui/test_computeresource_vmware.py
tests/foreman/ui/test_containerimagetag.py
tests/foreman/ui/test_contentcredentials.py
tests/foreman/ui/test_contenthost.py
tests/foreman/ui/test_contentview.py
tests/foreman/ui/test_dashboard.py
tests/foreman/ui/test_discoveredhost.py
tests/foreman/ui/test_discoveryrule.py
tests/foreman/ui/test_domain.py
tests/foreman/ui/test_errata.py
tests/foreman/ui/test_hardwaremodel.py
tests/foreman/ui/test_hostgroup.py
tests/foreman/ui/test_ldap_authentication.py
tests/foreman/ui/test_location.py
tests/foreman/ui/test_modulestreams.py
tests/foreman/ui/test_organization.py
tests/foreman/ui/test_oscappolicy.py
tests/foreman/ui/test_oscaptailoringfile.py
tests/foreman/ui/test_package.py
tests/foreman/ui/test_product.py
tests/foreman/ui/test_reporttemplates.py
tests/foreman/ui/test_repository.py
tests/foreman/ui/test_role.py
tests/foreman/ui/test_settings.py
tests/foreman/ui/test_subscription.py
tests/foreman/ui/test_syncplan.py
tests/foreman/ui/test_sync.py
tests/foreman/ui/test_templatesync.py
tests/foreman/ui/test_usergroup.py

Is it intentional?

@Gauravtalreja1
Copy link
Collaborator

@ogajduse We had a discussion on the original PR about this and @omkarkhatavkar confirmed that he's only targetting tests/foreman/api in this PR and he will continue on other modules in separate PRs
#12989 (comment)

@ogajduse
Copy link
Member

@omkarkhatavkar black seems to be not happy about the formatting, can you please fix it?

@omkarkhatavkar omkarkhatavkar force-pushed the cherrypick_update_target_sat_6_12 branch from 5887a71 to 7ebd862 Compare November 16, 2023 06:31
@omkarkhatavkar
Copy link
Author

trigger: test-robottelo
pod_resource_size: extra_large

@ogajduse
Copy link
Member

trigger: test-robottelo
pod_resource_size: extra_extra_large

@ogajduse
Copy link
Member

trigger: test-robottelo
pod_resources_size: extra_extra_large

@ogajduse
Copy link
Member

PRT passed, merging

@ogajduse ogajduse merged commit dc10643 into SatelliteQE:6.12.z Nov 16, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
No-CherryPick PR doesnt need CherryPick to previous branches
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Failed-AutoCherryPick] - removing the from nailgun import entities and moving target_sat, module_target_sat
4 participants