Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add test for SCA subscription report #13083

Merged
merged 3 commits into from
Nov 16, 2023
Merged

Add test for SCA subscription report #13083

merged 3 commits into from
Nov 16, 2023

Conversation

vsedmik
Copy link
Contributor

@vsedmik vsedmik commented Nov 14, 2023

Problem Statement

Satellite 6.15 implemented new report template for SCA-enabled orgs. We need to verify the report is rendered correctly.

Solution

This PR adds a test which generates the template and checks it contains the correct values.

@vsedmik vsedmik added API Issues and PRs involving the API No-CherryPick PR doesnt need CherryPick to previous branches Stream Introduced in or relating directly to Satellite Stream/Master labels Nov 14, 2023
@vsedmik vsedmik self-assigned this Nov 14, 2023
@vsedmik vsedmik requested a review from a team as a code owner November 14, 2023 11:16
@vsedmik
Copy link
Contributor Author

vsedmik commented Nov 14, 2023

trigger: test-robottelo
pytest: tests/foreman/api/test_reporttemplates.py -k test_positive_installed_products

vijaysawant
vijaysawant reviewed Nov 15, 2023
View reviewed changes
Copy link
Contributor

@vijaysawant vijaysawant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

query at ActivationKey(...).create() with additional non-blocking suggestions

tests/foreman/api/test_reporttemplates.py Show resolved Hide resolved
tests/foreman/api/test_reporttemplates.py Outdated Show resolved Hide resolved
tests/foreman/api/test_reporttemplates.py Outdated Show resolved Hide resolved
@vijaysawant
Copy link
Contributor

looks good to me.. 👍

@pondrejk
Copy link
Contributor

trigger: test-robottelo
pytest: tests/foreman/api/test_reporttemplates.py -k test_positive_installed_products

@pondrejk pondrejk merged commit 3e1f600 into SatelliteQE:master Nov 16, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vijaysawant vijaysawant vijaysawant left review comments

@pondrejk pondrejk pondrejk approved these changes

Assignees

@vsedmik vsedmik

Labels
API Issues and PRs involving the API No-CherryPick PR doesnt need CherryPick to previous branches Stream Introduced in or relating directly to Satellite Stream/Master
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vsedmik @vijaysawant @pondrejk