Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add basic fixture cli #13101

Merged
merged 1 commit into from
Nov 22, 2023
Merged

Conversation

JacobCallahan
Copy link
Member

This change adds a new fixture_cli.py script under the scripts directory.

The basic usage of this script is to take in a space-separated list of global fixtures and run them together in a single temporary test.

e.g. python scripts/fixture_cli.py module_ak_with_synced_repo module_lce

Additionally, I had to make some minor adjustments to a couple of plugins since this temporary test doesn't follow the same rules as the rest of our framework.

@JacobCallahan JacobCallahan added enhancement An addition to the robottelo framework CherryPick PR needs CherryPick to previous branches 6.12.z Introduced in or relating directly to Satellite 6.12 6.13.z Introduced in or relating directly to Satellite 6.13 6.14.z Introduced in or relating directly to Satellite 6.14 labels Nov 15, 2023
@JacobCallahan JacobCallahan requested a review from a team as a code owner November 15, 2023 20:56
@JacobCallahan JacobCallahan force-pushed the fixture-cli branch 4 times, most recently from bd953ad to 979da31 Compare November 15, 2023 21:37
@JacobCallahan JacobCallahan requested a review from a team November 15, 2023 21:44
Copy link
Contributor

@sambible sambible left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Neat idea. Would be cool to see the ability to pull in test file specific fixtures as well!

This change adds a new fixture_cli.py script under the scripts
directory.

The basic usage of this script is to take in a space-separated list
of global fixtures and run them together in a single temporary test.

e.g. python scripts/fixture_cli.py module_ak_with_synced_repo module_lce

Additionally, I had to make some minor adjustments to a couple of
plugins since this temporary test doesn't follow the same rules as the
rest of our framework.
@JacobCallahan
Copy link
Member Author

@jyejare
Copy link
Member

jyejare commented Nov 22, 2023

@JacobCallahan We could improve to read fixture names automatically from global fixture module instead of providing them on command as arguments.

@JacobCallahan
Copy link
Member Author

@JacobCallahan We could improve to read fixture names automatically from global fixture module instead of providing them on command as arguments.

We discussed this in a meeting and decided to consider what we're looking for with this request and revisit some form of fixture selection in the future.

@JacobCallahan JacobCallahan merged commit 150e7a2 into SatelliteQE:master Nov 22, 2023
5 checks passed
@JacobCallahan JacobCallahan deleted the fixture-cli branch November 22, 2023 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.12.z Introduced in or relating directly to Satellite 6.12 6.13.z Introduced in or relating directly to Satellite 6.13 6.14.z Introduced in or relating directly to Satellite 6.14 CherryPick PR needs CherryPick to previous branches enhancement An addition to the robottelo framework
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants