Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[6.14.z] use one fixture instead of multiple and remove problematic one #13122

Conversation

Satellite-QE
Copy link
Collaborator

Cherrypick of PR: #13107

Problem Statement

Hosts-Content component -> CLI tests were failing with AttributeError because of fixture module_gt_manifest_org which is being used inside moduled scoped fixture rh_repo_gt_manifest of repository.py

failed on setup with "AttributeError: '_io.BytesIO' object has no attribute 'filename'"

The fixture rh_repo_gt_manifest simply creates new org with GT menifest, create rhst repo, sync and return the respective repo. Rest of fixtures from test module uses module_sca_manifest_org which creates module org with menifest.
The above setup were problematic.

Solution

Collect scattered fixtures into single module scoped fixture and use it.

Related Issues

No

@Satellite-QE Satellite-QE added 6.14.z Introduced in or relating directly to Satellite 6.14 Auto_Cherry_Picked Automatically cherrypicked PR using GHA No-CherryPick PR doesnt need CherryPick to previous branches labels Nov 17, 2023
@damoore044
Copy link
Contributor

trigger: test-robottelo
pytest: tests/foreman/cli/test_contentaccess.py -k 'test_positive_list_installable_updates or test_positive_erratum_installable or test_negative_unregister_and_pull_content'

@damoore044 damoore044 added the AutoMerge_Cherry_Picked The cherrypicked PRs of master PR would be automerged if all checks passing label Nov 17, 2023
@Satellite-QE Satellite-QE merged commit 32ac580 into 6.14.z Nov 17, 2023
22 checks passed
@Satellite-QE Satellite-QE deleted the cherry-pick-6.14.z-3052485303413c9c917e4dda140879ec1a99d770 branch November 17, 2023 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.14.z Introduced in or relating directly to Satellite 6.14 Auto_Cherry_Picked Automatically cherrypicked PR using GHA AutoMerge_Cherry_Picked The cherrypicked PRs of master PR would be automerged if all checks passing No-CherryPick PR doesnt need CherryPick to previous branches
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants