Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RFE] Check RHEL Lifecycle status in ContentHost UI #13162

Merged
merged 3 commits into from
Dec 14, 2023
Merged

[RFE] Check RHEL Lifecycle status in ContentHost UI #13162

merged 3 commits into from
Dec 14, 2023

Conversation

damoore044
Copy link
Contributor

@damoore044 damoore044 commented Nov 22, 2023 •
edited
Loading

Extend UI::test_contenthost.py::test_positive_end_to_end:

  • To check the new 'RHEL Lifecycle status' of the rhel host, and check host status.

Two helper methods:

  • get_supported_rhel_versions() : to get all supported rhel versions for contenthosts in satellite.
  • get_rhel_lifecycle_support(rhel_version) : to get expected RHEL Lifecycle status string,
    based on provided rhel_version# vs all supported versions# discovered.

@damoore044 damoore044 added the No-CherryPick PR doesnt need CherryPick to previous branches label Nov 22, 2023
@damoore044

This comment was marked as duplicate.

Sign in to view
@damoore044

This comment was marked as duplicate.

Sign in to view
@damoore044 damoore044 added the Stream Introduced in or relating directly to Satellite Stream/Master label Nov 22, 2023
@damoore044

This comment was marked as duplicate.

Sign in to view
@damoore044 damoore044 added CherryPick PR needs CherryPick to previous branches 6.15.z Introduced in or relating directly to Satellite 6.15 and removed No-CherryPick PR doesnt need CherryPick to previous branches labels Nov 28, 2023
@damoore044
Copy link
Contributor Author

trigger: test-robottelo
pytest: tests/foreman/ui/test_contenthost.py -k test_positive_end_to_end

vsedmik
vsedmik reviewed Nov 29, 2023
View reviewed changes
tests/foreman/ui/test_contenthost.py Outdated Show resolved Hide resolved
tests/foreman/ui/test_contenthost.py Outdated Show resolved Hide resolved
@damoore044

This comment was marked as duplicate.

Sign in to view
@damoore044

This comment was marked as duplicate.

Sign in to view
@damoore044
Copy link
Contributor Author

trigger: test-robottelo
pytest: tests/foreman/ui/test_contenthost.py::test_positive_end_to_end

@damoore044 damoore044 force-pushed the 6.15.0-RFE branch 2 times, most recently from bb2058a to ba1f0b3 Compare November 30, 2023 14:47
@damoore044
Copy link
Contributor Author

Build [4770]: Pass (1/1)
Rebased and fixed some typos in comments. No code changes since the passing build.

@Griffin-Sullivan
Copy link
Contributor

is this ready for review?

@damoore044
Copy link
Contributor Author

@Griffin-Sullivan Yes ready to review!
will start another prt as hiding an old comment generated a failed run (Build 4771, 2.3 seconds)

@damoore044
Copy link
Contributor Author

trigger: test-robottelo
pytest: tests/foreman/ui/test_contenthost.py::test_positive_end_to_end

@damoore044 damoore044 marked this pull request as ready for review November 30, 2023 15:40
@damoore044 damoore044 requested a review from a team as a code owner November 30, 2023 15:40
@damoore044 damoore044 self-assigned this Nov 30, 2023
sambible
sambible requested changes Nov 30, 2023
View reviewed changes
tests/foreman/ui/test_contenthost.py Outdated Show resolved Hide resolved
@damoore044 damoore044 requested a review from sambible November 30, 2023 18:43
lhellebr
lhellebr reviewed Dec 1, 2023
View reviewed changes
tests/foreman/ui/test_contenthost.py Show resolved Hide resolved
tests/foreman/ui/test_contenthost.py Outdated Show resolved Hide resolved
tests/foreman/ui/test_contenthost.py Outdated Show resolved Hide resolved
@damoore044 damoore044 force-pushed the 6.15.0-RFE branch 2 times, most recently from 3945b10 to 266b3b5 Compare December 11, 2023 19:46
@damoore044 damoore044 requested a review from a team as a code owner December 11, 2023 19:46
@damoore044 damoore044 force-pushed the 6.15.0-RFE branch 3 times, most recently from 0dcddde to 0cc4900 Compare December 11, 2023 20:07
@damoore044
Copy link
Contributor Author

trigger: test-robottelo
pytest: tests/foreman/ui/test_contenthost.py::test_positive_end_to_end

@damoore044 damoore044 requested a review from lhellebr December 11, 2023 20:14
@damoore044
Copy link
Contributor Author

trigger: test-robottelo
pytest: tests/foreman/ui/test_contenthost.py::test_positive_end_to_end

@damoore044
Copy link
Contributor Author

trigger: test-robottelo
pytest: tests/foreman/ui/test_contenthost.py::test_positive_end_to_end

@damoore044
Copy link
Contributor Author

trigger: test-robottelo
pytest: tests/foreman/ui/test_contenthost.py::test_positive_end_to_end

@damoore044 damoore044 requested review from a team and removed request for a team December 13, 2023 13:16
@damoore044
Copy link
Contributor Author

trigger: test-robottelo
pytest: tests/foreman/ui/test_contenthost.py::test_positive_end_to_end

@vsedmik vsedmik added the AutoMerge_Cherry_Picked The cherrypicked PRs of master PR would be automerged if all checks passing label Dec 14, 2023
@vsedmik vsedmik merged commit 3fa442f into SatelliteQE:master Dec 14, 2023
7 checks passed
@Satellite-QE Satellite-QE mentioned this pull request Dec 14, 2023
Merged
github-actions bot pushed a commit that referenced this pull request Dec 14, 2023
@damoore044 @web-flow
[RFE] Check RHEL Lifecycle status in ContentHost UI (#13162)
206605c 
* Check RHEL Lifecycle status in ContentHost UI

* Finish extension for RHEL lifecycle status

* Intermittent prt failures for search, errata install

(cherry picked from commit 3fa442f)
shweta83 pushed a commit to shweta83/robottelo that referenced this pull request Apr 10, 2024
@damoore044 @shweta83
[RFE] Check RHEL Lifecycle status in ContentHost UI (SatelliteQE#13162)
acce40f 
* Check RHEL Lifecycle status in ContentHost UI

* Finish extension for RHEL lifecycle status

* Intermittent prt failures for search, errata install
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vsedmik vsedmik vsedmik approved these changes

@sambible sambible sambible approved these changes

@lhellebr lhellebr Awaiting requested review from lhellebr

Assignees

@damoore044 damoore044

Labels
6.15.z Introduced in or relating directly to Satellite 6.15 AutoMerge_Cherry_Picked The cherrypicked PRs of master PR would be automerged if all checks passing CherryPick PR needs CherryPick to previous branches RFE Issues that are requesting an enhancement to robottelo Stream Introduced in or relating directly to Satellite Stream/Master
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@damoore044 @Griffin-Sullivan @lhellebr @sambible @vsedmik