fix for remote execution cli tests #13167
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pondrejk
added
TestFailure
jyejare
approved these changes
Nov 23, 2023
| @@ -1307,7 +1315,9 @@ def test_positive_run_job_on_host_registered_to_pull_provider( | |||
| 'effective-user': f'{username}', | |||
| } | |||
| ) | |||
| assert_job_invocation_result(invocation_command['id'], rhel_contenthost.hostname) | |||
| assert_job_invocation_result( | |||
| target_sat, invocation_command['id'], rhel_contenthost.hostname | |||
There was a problem hiding this comment.
@pondrejk test_positive_run_job_on_host_registered_to_pull_provider is using both module_targe_sat and target_sat is this intended?
There was a problem hiding this comment.
ugh, god no, good chatch :) this was also introduced by 11544
jameerpathan111
approved these changes
Nov 23, 2023
This was referenced Nov 23, 2023
github-actions bot
pushed a commit
that referenced
this pull request
Nov 23, 2023
(cherry picked from commit ab77c09)
pondrejk
added a commit
that referenced
this pull request
Nov 24, 2023
(cherry picked from commit ab77c09)
This was referenced Nov 30, 2023
shweta83
pushed a commit
to shweta83/robottelo
that referenced
this pull request
Apr 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem Statement
#11544 changed the number of required arguments of the
assert_job_invocation_resultfunction, but it didn't update all the callers accordingly, leading to all cli rex tests failing in the stream automation runSolution
changed callers
Related Issues
#11544 requires manual cherry-picks, when that happens, this pr should be cherrypicked closely afterwards