-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes to Master due to new 6.15 and 6.16 #13169
Conversation
@@ -16,9 +16,9 @@ class Colored(Box): | |||
|
|||
|
|||
# This should be updated after each version branch | |||
SATELLITE_VERSION = "6.15" | |||
SATELLITE_VERSION = "6.16" | |||
SATELLITE_OS_VERSION = "8" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Or "9" right ? 😉
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not yet confirmed I believe, anyways OS Version would be provided by CI (either 8 or 9) for executing tests in CI! This is been managed by conf files!
If it supports on RHEL 9 , we can switch this drop down version to 9.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we use settings.robottelo.rhel_version here provided by CI instead of this constant, so this can be managed by configs for each job for 8/9?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Gauravtalreja1 Upon looking the usage of this variable it is being used in deciding(returning) capsule repo in SatelliteCapsuleRepository
class of repository_mixins.py
module.
We should deprecate the use of this variable and switch the url def to use rhel_version conf settings.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I dont block this PR on it as that change has to be cherrypicked back to all zBranches but this PR is not for cherrypicking
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
agree @jyejare , we could start with master for this deprecation or else you could handle this in different PR which we can cherrypick to older branch, but it's no blocker
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remove any current stream markers
@JacobCallahan I did not because I would like Teams to decide and remove the markers on the tests that they think are not applicable for new stream version. There is possibility that the feature is divided into two parts and hence the test/feature is still applicable with new stream version. |
@jyejare if you'd like to tag a rep for teams that own tests with that marker, please do. Our intent or the stream marker is that they are only applied to new tests covering functionality introduced in that stream. These markers should then be purged with each new stream cycle. In the future, this purge will be automated. |
@@ -16,9 +16,9 @@ class Colored(Box): | |||
|
|||
|
|||
# This should be updated after each version branch | |||
SATELLITE_VERSION = "6.15" | |||
SATELLITE_VERSION = "6.16" | |||
SATELLITE_OS_VERSION = "8" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we use settings.robottelo.rhel_version here provided by CI instead of this constant, so this can be managed by configs for each job for 8/9?
@JacobCallahan @Gauravtalreja1 Comments addressed ! |
@Gauravtalreja1 please merge if you're satisfied with the changes. |
Changes to Master due to new 6.15
Problem Statement
New 6.15 downstream and master points to stream that is 6.16
Solution
Related Issues
#13168